Re: [PATCH v5] ARM: EXYNOS: Add MFC device tree support

[Kukjin Kim <kgene.kim@samsung.com>]

On 10/23/12 19:12, Arun Kumar K wrote:
> Hi Seungwoo Kim,
>
> Thank you for the review.
>
>>> +
>>> +     /* Reserve memory for MFC only if it's available */
>>> +     mfc_mem.compatible = "samsung,mfc-v6";
>>> +     if (of_scan_flat_dt(s5p_fdt_find_mfc_mem,&mfc_mem))
>>
>> of_scan_flat_dt() is called but it does not have __init on its
>> definition. So this causes section mismatch.
>>
>
> The function of_scan_flat_dt is having __init in its definition.

Yes.

> I hope you meant the function s5p_fdt_find_mfc_mem which is not
> defined with __init and causing section mismatch.

I think so.

> I will correct this and post an updated patch.

I fixed when I applied.

Seung-Woo, thanks for your reporting.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.