All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Holler <holler@ahsoftware.de>
To: Thomas Meyer <thomas@m3y3r.de>
Cc: linux-kernel@vger.kernel.org, airlied <airlied@linux.ie>,
	"David S. Miller" <davem@davemloft.net>,
	Will Deacon <Will.Deacon@arm.com>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	stable@vger.kernel.org
Subject: Re: "read_current_timer" undefined!
Date: Fri, 19 Oct 2012 08:19:27 +0200	[thread overview]
Message-ID: <5080F0EF.5040100@ahsoftware.de> (raw)
In-Reply-To: <1350562575.1270.3.camel@localhost.localdomain>

Hello,

Am 18.10.2012 14:16, schrieb Thomas Meyer:

> ERROR: "read_current_timer" [drivers/gpu/drm/udl/udl.ko] undefined!
> ERROR: "read_current_timer" [crypto/tcrypt.ko] undefined!

There is already a long thread about that, along with patches:

https://lkml.org/lkml/2012/10/9/393

If you need a patch for 3.6, here is what I did before I found the above 
thread:

------------------------------
 From a026451fdc98a5981e10a18ffa394e53a40b0691 Mon Sep 17 00:00:00 2001
From: Alexander Holler <holler@ahsoftware.de>
Date: Thu, 18 Oct 2012 07:29:39 +0200
Subject: [PATCH] arm: arch timer: export read_current_timer()

Exporting read_current_timmer is needed e.g. for users of get_cycles()
like udlfb which otherwise can't be build as a module.

This seems to have been forgotten in
commit 923df96b9f31b7d08d8438ff9677326d9537accf.

Cc: stable@vger.kernel.org
Signed-off-by: Alexander Holler <holler@ahsoftware.de>
---
  arch/arm/kernel/arch_timer.c |    2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/arm/kernel/arch_timer.c b/arch/arm/kernel/arch_timer.c
index cf25880..7f24d1f 100644
--- a/arch/arm/kernel/arch_timer.c
+++ b/arch/arm/kernel/arch_timer.c
@@ -19,6 +19,7 @@
  #include <linux/interrupt.h>
  #include <linux/of_irq.h>
  #include <linux/io.h>
+#include <linux/export.h>

  #include <asm/cputype.h>
  #include <asm/localtimer.h>
@@ -232,6 +233,7 @@ int read_current_timer(unsigned long *timer_val)
  	*timer_val = arch_counter_get_cntpct();
  	return 0;
  }
+EXPORT_SYMBOL(read_current_timer);

  static struct clocksource clocksource_counter = {
  	.name	= "arch_sys_counter",
-- 
1.7.3.4
------------------------------

Regards,

Alexander

  reply	other threads:[~2012-10-19  6:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-18 12:16 "read_current_timer" undefined! Thomas Meyer
2012-10-19  6:19 ` Alexander Holler [this message]
2012-10-19  9:18   ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5080F0EF.5040100@ahsoftware.de \
    --to=holler@ahsoftware.de \
    --cc=Will.Deacon@arm.com \
    --cc=airlied@linux.ie \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=stable@vger.kernel.org \
    --cc=thomas@m3y3r.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.