From: Asias He <asias@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH] vhost-blk: Add vhost-blk support v2
Date: Fri, 19 Oct 2012 14:44:05 +0800 [thread overview]
Message-ID: <5080F6B5.5070608@redhat.com> (raw)
In-Reply-To: <87d30go1g7.fsf@rustcorp.com.au>
On 10/18/2012 12:20 PM, Rusty Russell wrote:
> Asias He <asias@redhat.com> writes:
>>>> +#define BLK_HDR 0
>>>
>>> What's this for, exactly? Please add a comment.
>>
>> The block headr is in the first and separate buffer.
>
> Please don't assume this! We're trying to fix all the assumptions in
> qemu at the moment.
>
> vhost_net handles this correctly, taking bytes off the descriptor chain
> as required.
Well, I will switch to "no assumption about the buffer layout" in next
version.
--
Asias
prev parent reply other threads:[~2012-10-19 6:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-09 8:05 [PATCH] vhost-blk: Add vhost-blk support v2 Asias He
2012-10-09 17:39 ` Christoph Hellwig
2012-10-10 2:27 ` Asias He
2012-10-09 17:39 ` Christoph Hellwig
2012-10-11 12:41 ` Michael S. Tsirkin
2012-10-12 13:18 ` Asias He
2012-10-13 22:58 ` Michael S. Tsirkin
2012-10-18 4:20 ` Rusty Russell
2012-10-18 6:30 ` Michael S. Tsirkin
2012-10-23 0:07 ` Rusty Russell
2012-10-24 3:08 ` Asias He
2012-10-19 6:44 ` Asias He [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5080F6B5.5070608@redhat.com \
--to=asias@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.