From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eKcrg-0000Jx-M9 for ath10k@lists.infradead.org; Fri, 01 Dec 2017 04:23:54 +0000 MIME-Version: 1.0 Date: Fri, 01 Dec 2017 09:53:30 +0530 From: akolli@codeaurora.org Subject: Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4 In-Reply-To: <87bmjjzppd.fsf@kamboji.qca.qualcomm.com> References: <1512046701-14435-1-git-send-email-akolli@qti.qualcomm.com> <1512046701-14435-3-git-send-email-akolli@qti.qualcomm.com> <87k1y7zqtj.fsf@kamboji.qca.qualcomm.com> <87bmjjzppd.fsf@kamboji.qca.qualcomm.com> Message-ID: <5080a68538fd2d883e15bacaa969661b@codeaurora.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Kalle Valo Cc: linux-wireless-owner@vger.kernel.org, Anilkumar Kolli , =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org T24gMjAxNy0xMS0zMCAyMjowOCwgS2FsbGUgVmFsbyB3cm90ZToKPiBUb2tlIEjDuGlsYW5kLUrD uHJnZW5zZW4gPHRva2VAdG9rZS5kaz4gd3JpdGVzOgo+IAo+Pj4+ICtzdHJ1Y3QgYXRoMTBrXzEw XzJfcGVlcl90eF9zdGF0cyB7Cj4+Pj4gKwl1OCByYXRlY29kZVtQRUVSX1NUQVRTX0ZPUl9OT19P Rl9QUERVU107Cj4+Pj4gKwl1OCBzdWNjZXNzX3BrdHNbUEVFUl9TVEFUU19GT1JfTk9fT0ZfUFBE VVNdOwo+Pj4+ICsJX19sZTE2IHN1Y2Nlc3NfYnl0ZXNbUEVFUl9TVEFUU19GT1JfTk9fT0ZfUFBE VVNdOwo+Pj4+ICsJdTggcmV0cnlfcGt0c1tQRUVSX1NUQVRTX0ZPUl9OT19PRl9QUERVU107Cj4+ Pj4gKwlfX2xlMTYgcmV0cnlfYnl0ZXNbUEVFUl9TVEFUU19GT1JfTk9fT0ZfUFBEVVNdOwo+Pj4+ ICsJdTggZmFpbGVkX3BrdHNbUEVFUl9TVEFUU19GT1JfTk9fT0ZfUFBEVVNdOwo+Pj4+ICsJX19s ZTE2IGZhaWxlZF9ieXRlc1tQRUVSX1NUQVRTX0ZPUl9OT19PRl9QUERVU107Cj4+Pj4gKwl1OCBm bGFnc1tQRUVSX1NUQVRTX0ZPUl9OT19PRl9QUERVU107Cj4+Pj4gKwlfX2xlMzIgdHhfZHVyYXRp b247Cj4+Pj4gKwl1OCB0eF9wcGR1X2NudDsKPj4+PiArCXU4IHBlZXJfaWQ7Cj4+Pj4gK30gX19w YWNrZWQ7Cj4+PiAKPj4+IFRva2UsIGhvcGVmdWxseSB0aGUgdHhfZHVyYXRpb24gdmFsdWUgaGVy ZSBoZWxwcyB3aXRoIEFURgo+Pj4gaW1wbGVtZW50YXRpb24KPj4+IHVzaW5nIFFDQTk4OFguCj4+ IAo+PiBBd2Vzb21lISBXaGF0J3MgdGhlIHNlbWFudGljcyBvZiB0aGlzIGZpZWxkPyBKdXN0IHRv dGFsCj4+IGR1cmF0aW9uIHNwZW50IHNlcnZpbmcgdGhhdCBzdGF0aW9uIGluIHRoZSByZXBvcnRp bmcgaW50ZXJ2YWw/Cj4+IERvZXMgaXQgaW5jbHVkZSByZXRyeSBhdHRlbXB0cz8KPiAKPiBJIGhh dmUgbm8gY2x1ZSA6KSBJIGp1c3Qgbm90aWNlZCB0aGlzIHdoaWxlIEkgd2FzIHJldmlld2luZyB0 aGUgcGF0Y2gKPiBpbnRlcm5hbGx5IGFuZCBpbW1lZGlhdGVseSByZWNhbGxlZCBvdXIgZGlzY3Vz c2lvbnMgYXQgU2VvdWwuIEkgY2FuIHRyeQo+IHRvIGZpbmQgb3V0LCBidXQgdGhhdCB3aWxsIHRh a2UgYSBsb25nIHRpbWUgYXMgSSBoYXZlIHdheSB0b28gbXVjaCAKPiBzdHVmZgo+IHBlbmRpbmcg YXQgdGhlIG1vbWVudC4gSG9wZWZ1bGx5IHNvbWVvbmUgbW9yZSBrbm93bGVkZ2VhYmxlIAo+IChB bmlsa3VtYXI/KQo+IGNhbiBjaGltZSBpbiBhbmQgaGVscC4KCnR4X2R1cmF0aW9uIGlzIGFnZ3Jl Z2F0ZSB0aW1lIGR1cmF0aW9uIG9mIDQgUFBEVSBzZW50IHRvIFNUQS4KRlcgc2VuZHMgdGhlc2Ug dmFsdWVzIGZvciByZXRyeSBwYWNrZXRzIGFsc28uCgpUaGFua3MsCkFuaWwuCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwphdGgxMGsgbWFpbGluZyBsaXN0 CmF0aDEwa0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vYXRoMTBrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:35320 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752129AbdLAEXc (ORCPT ); Thu, 30 Nov 2017 23:23:32 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Date: Fri, 01 Dec 2017 09:53:30 +0530 From: akolli@codeaurora.org To: Kalle Valo Cc: =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, Anilkumar Kolli , linux-wireless-owner@vger.kernel.org Subject: Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4 In-Reply-To: <87bmjjzppd.fsf@kamboji.qca.qualcomm.com> References: <1512046701-14435-1-git-send-email-akolli@qti.qualcomm.com> <1512046701-14435-3-git-send-email-akolli@qti.qualcomm.com> <87k1y7zqtj.fsf@kamboji.qca.qualcomm.com> <87bmjjzppd.fsf@kamboji.qca.qualcomm.com> Message-ID: <5080a68538fd2d883e15bacaa969661b@codeaurora.org> (sfid-20171201_052513_859058_810F97D2) Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2017-11-30 22:08, Kalle Valo wrote: > Toke Høiland-Jørgensen writes: > >>>> +struct ath10k_10_2_peer_tx_stats { >>>> + u8 ratecode[PEER_STATS_FOR_NO_OF_PPDUS]; >>>> + u8 success_pkts[PEER_STATS_FOR_NO_OF_PPDUS]; >>>> + __le16 success_bytes[PEER_STATS_FOR_NO_OF_PPDUS]; >>>> + u8 retry_pkts[PEER_STATS_FOR_NO_OF_PPDUS]; >>>> + __le16 retry_bytes[PEER_STATS_FOR_NO_OF_PPDUS]; >>>> + u8 failed_pkts[PEER_STATS_FOR_NO_OF_PPDUS]; >>>> + __le16 failed_bytes[PEER_STATS_FOR_NO_OF_PPDUS]; >>>> + u8 flags[PEER_STATS_FOR_NO_OF_PPDUS]; >>>> + __le32 tx_duration; >>>> + u8 tx_ppdu_cnt; >>>> + u8 peer_id; >>>> +} __packed; >>> >>> Toke, hopefully the tx_duration value here helps with ATF >>> implementation >>> using QCA988X. >> >> Awesome! What's the semantics of this field? Just total >> duration spent serving that station in the reporting interval? >> Does it include retry attempts? > > I have no clue :) I just noticed this while I was reviewing the patch > internally and immediately recalled our discussions at Seoul. I can try > to find out, but that will take a long time as I have way too much > stuff > pending at the moment. Hopefully someone more knowledgeable > (Anilkumar?) > can chime in and help. tx_duration is aggregate time duration of 4 PPDU sent to STA. FW sends these values for retry packets also. Thanks, Anil.