From mboxrd@z Thu Jan  1 00:00:00 1970
From: cpebenito@tresys.com (Christopher J. PeBenito)
Date: Fri, 19 Oct 2012 09:17:33 -0400
Subject: [refpolicy] [PATCH] Change deprecated gnome_role to new
	gnome_role_gconfd
In-Reply-To: <1349878949.2331.7.camel@d30.localdomain>
References: <1349797851-12004-1-git-send-email-dominick.grift@gmail.com>
	<5075798F.7060805@tresys.com>
	<1349878226.2331.4.camel@d30.localdomain>
	<1349878949.2331.7.camel@d30.localdomain>
Message-ID: <508152ED.4050706@tresys.com>
To: refpolicy@oss.tresys.com
List-Id: refpolicy.oss.tresys.com

On 10/10/12 10:22, Dominick Grift wrote:
> 
> 
> On Wed, 2012-10-10 at 16:10 +0200, Dominick Grift wrote:
>>
>> On Wed, 2012-10-10 at 09:35 -0400, Christopher J. PeBenito wrote:
>>> On 10/09/12 11:50, Dominick Grift wrote:
>>>> Signed-off-by: Dominick Grift <dominick.grift@gmail.com>
>>>> diff --git a/policy/modules/roles/staff.te b/policy/modules/roles/staff.te
>>>> index e5aee97..2d1520d 100644
>>>> --- a/policy/modules/roles/staff.te
>>>> +++ b/policy/modules/roles/staff.te
>>>> @@ -93,7 +93,7 @@
>>>>  	')
>>>>  
>>>>  	optional_policy(`
>>>> -		gnome_role(staff_r, staff_t)
>>>> +		gnome_role_gconfd(staff_r, staff_t)
>>>>  	')
>>>>  
>>>>  	optional_policy(`
>>>> diff --git a/policy/modules/roles/sysadm.te b/policy/modules/roles/sysadm.te
>>>> index 44c198a..1803cfd 100644
>>>> --- a/policy/modules/roles/sysadm.te
>>>> +++ b/policy/modules/roles/sysadm.te
>>>> @@ -459,7 +459,7 @@
>>>>  	')
>>>>  
>>>>  	optional_policy(`
>>>> -		gnome_role(sysadm_r, sysadm_t)
>>>> +		gnome_role_gconfd(sysadm_r, sysadm_t)
>>>>  	')
>>>>  
>>>>  	optional_policy(`
>>>> diff --git a/policy/modules/roles/unprivuser.te b/policy/modules/roles/unprivuser.te
>>>> index 9f6d4c3..e354193 100644
>>>> --- a/policy/modules/roles/unprivuser.te
>>>> +++ b/policy/modules/roles/unprivuser.te
>>>> @@ -66,7 +66,7 @@
>>>>  	')
>>>   
>>>>  	optional_policy(`
>>>> -		gnome_role(user_r, user_t)
>>>> +		gnome_role_gconfd(user_r, user_t)
>>>>  	')
>>>>  
>>>>  	optional_policy(`
>>>
>>> Why was gnome_role() deprecated in the first place?
>>>
> 
> There is now also a gnome_role_gkeyringd() but its not called yet
> because its a work in progress ( it depends on freedeskop
> config/cache/data dirs)
> 
> So for example
> 
> Fedora will probably call gnome_role_gkeyringd() but not
> gnome_role_gconfd()
> 
> If you pile them all in one huge template then that allows for less
> flexibility

No.  I think it abstracts the gnome complexities away from other modules, and puts it where it rightly belongs, in the gnome module.

-- 
Chris PeBenito
Tresys Technology, LLC
www.tresys.com | oss.tresys.com