From: Elizabeth Figura <zfigura@codeweavers.com>
To: "Iván Ezequiel Rodriguez" <ivanrwcm25@gmail.com>
Cc: wine-devel@winehq.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] ntsync: reject wait ioctls with zero owner
Date: Wed, 01 Jul 2026 11:38:46 -0500 [thread overview]
Message-ID: <5081647.GXAFRqVoOG@camazotz> (raw)
In-Reply-To: <20260628024239.152852-5-ivanrwcm25@gmail.com>
On Saturday, 27 June 2026 21:42:39 CDT Iván Ezequiel Rodriguez wrote:
> setup_wait() already validates pad and flags but not owner, while
> Documentation/userspace-api/ntsync.rst requires EINVAL when owner is
> zero. Reject early before queueing waiters.
>
> Signed-off-by: Iván Ezequiel Rodriguez <ivanrwcm25@gmail.com>
> ---
> drivers/misc/ntsync.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/misc/ntsync.c b/drivers/misc/ntsync.c
> index 02c9d1192812..4a805919bb0c 100644
> --- a/drivers/misc/ntsync.c
> +++ b/drivers/misc/ntsync.c
> @@ -875,6 +875,9 @@ static int setup_wait(struct ntsync_device *dev,
> if (args->pad || (args->flags & ~NTSYNC_WAIT_REALTIME))
> return -EINVAL;
>
> + if (!args->owner)
> + return -EINVAL;
> +
> if (size >= sizeof(fds))
> return -EINVAL;
>
>
Reviewed-by: Elizabeth Figura <zfigura@codeweavers.com>
next prev parent reply other threads:[~2026-07-01 16:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-28 2:42 [PATCH 0/4] ntsync documentation, selftests, and owner validation Iván Ezequiel Rodriguez
2026-06-28 2:42 ` [PATCH 1/4] docs: ntsync: align uAPI ioctl names and struct layout with ntsync.h Iván Ezequiel Rodriguez
2026-07-01 16:37 ` Elizabeth Figura
2026-06-28 2:42 ` [PATCH 2/4] selftests: ntsync: fix wake_all CREATE_EVENT fd expectation Iván Ezequiel Rodriguez
2026-07-01 16:38 ` Elizabeth Figura
2026-06-28 2:42 ` [PATCH 3/4] selftests: ntsync: add wait argument validation tests Iván Ezequiel Rodriguez
2026-07-01 16:38 ` Elizabeth Figura
2026-06-28 2:42 ` [PATCH 4/4] ntsync: reject wait ioctls with zero owner Iván Ezequiel Rodriguez
2026-07-01 16:38 ` Elizabeth Figura [this message]
2026-07-01 16:45 ` [PATCH 0/4] ntsync documentation, selftests, and owner validation Elizabeth Figura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5081647.GXAFRqVoOG@camazotz \
--to=zfigura@codeweavers.com \
--cc=ivanrwcm25@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wine-devel@winehq.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.