From: Jonathan Cameron <jic23@kernel.org>
To: Roland Stigge <stigge@antcom.de>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Jonathan Cameron <jic23@cam.ac.uk>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH 2/4] staging:iio:lpc32xx_adc: Use resource_size instead of opencoding it
Date: Fri, 19 Oct 2012 16:26:16 +0100 [thread overview]
Message-ID: <50817118.80807@kernel.org> (raw)
In-Reply-To: <50802B4F.3040709@antcom.de>
On 10/18/2012 05:16 PM, Roland Stigge wrote:
> On 10/18/2012 04:43 PM, Lars-Peter Clausen wrote:
>> Fixes the following error from coccicheck:
>> drivers/staging/iio/adc/lpc32xx_adc.c:153:43-46: ERROR: Missing resource_size with res
>>
>> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
>
> Acked-by: Roland Stigge <stigge@antcom.de>
Applied to togreg branch of iio.git
>
>> Cc: Roland Stigge <stigge@antcom.de>
>> ---
>> drivers/staging/iio/adc/lpc32xx_adc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/iio/adc/lpc32xx_adc.c b/drivers/staging/iio/adc/lpc32xx_adc.c
>> index 7e9bd00..10c5962 100644
>> --- a/drivers/staging/iio/adc/lpc32xx_adc.c
>> +++ b/drivers/staging/iio/adc/lpc32xx_adc.c
>> @@ -150,7 +150,7 @@ static int __devinit lpc32xx_adc_probe(struct platform_device *pdev)
>>
>> info = iio_priv(iodev);
>>
>> - info->adc_base = ioremap(res->start, res->end - res->start + 1);
>> + info->adc_base = ioremap(res->start, resource_size(res));
>> if (!info->adc_base) {
>> dev_err(&pdev->dev, "failed mapping memory\n");
>> retval = -EBUSY;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2012-10-19 17:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 14:43 [PATCH 1/4] staging:iio: Don't compare boolean values with true/false Lars-Peter Clausen
2012-10-18 14:43 ` [PATCH 2/4] staging:iio:lpc32xx_adc: Use resource_size instead of opencoding it Lars-Peter Clausen
2012-10-18 16:16 ` Roland Stigge
2012-10-19 15:26 ` Jonathan Cameron [this message]
2012-10-18 14:43 ` [PATCH 3/4] iio: Don't compare boolean values to true/false Lars-Peter Clausen
2012-10-19 15:27 ` Jonathan Cameron
2012-10-18 14:43 ` [PATCH 4/4] iio: at91_adc: Use devm_kcalloc to allocate arrays Lars-Peter Clausen
2012-10-19 8:54 ` Maxime Ripard
2012-10-19 15:32 ` Jonathan Cameron
2012-10-19 15:24 ` [PATCH 1/4] staging:iio: Don't compare boolean values with true/false Jonathan Cameron
2012-10-19 17:55 ` Lars-Peter Clausen
2012-10-19 17:59 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50817118.80807@kernel.org \
--to=jic23@kernel.org \
--cc=jic23@cam.ac.uk \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=stigge@antcom.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.