All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: "Kim, Milo" <Milo.Kim@ti.com>
Cc: "cbou@mail.ru" <cbou@mail.ru>,
	Anton Vorontsov <anton.vorontsov@linaro.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] lp8788-charger: fix ADC channel names
Date: Fri, 19 Oct 2012 16:41:11 +0100	[thread overview]
Message-ID: <50817497.5070900@kernel.org> (raw)
In-Reply-To: <A874F61F95741C4A9BA573A70FE3998F64178F9F@DQHE02.ent.ti.com>

On 10/18/2012 07:11 AM, Kim, Milo wrote:
>  LP8788 IIO ADC driver and platform data have specific naming convention
>  for ADC channels. That is using prefix 'lp8788_'.
>  To keep this rule, ADC channel names are changed.
> 
It's a little unusual to name the consumer side of the map so specifically.
If you want to do so it's up to you though (and it obviously has to match)
that provided in platform_data including the default map in the iio driver.
> Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
> ---
>  drivers/power/lp8788-charger.c |   14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/power/lp8788-charger.c b/drivers/power/lp8788-charger.c
> index 614e6aa..02fc9ab 100644
> --- a/drivers/power/lp8788-charger.c
> +++ b/drivers/power/lp8788-charger.c
> @@ -600,13 +600,13 @@ static void lp8788_setup_adc_channel(const char *consumer_name,
>  	struct iio_channel *chan;
>  	enum lp8788_adc_id id;
>  	const char *chan_name[LPADC_MAX] = {
> -		[LPADC_VBATT_5P5] = "vbatt-5p5",
> -		[LPADC_VBATT_6P0] = "vbatt-6p0",
> -		[LPADC_VBATT_5P0] = "vbatt-5p0",
> -		[LPADC_ADC1]      = "adc1",
> -		[LPADC_ADC2]      = "adc2",
> -		[LPADC_ADC3]      = "adc3",
> -		[LPADC_ADC4]      = "adc4",
> +		[LPADC_VBATT_5P5] = "lp8788_vbatt_5p5",
> +		[LPADC_VBATT_6P0] = "lp8788_vbatt_6p0",
> +		[LPADC_VBATT_5P0] = "lp8788_vbatt_5p0",
> +		[LPADC_ADC1]      = "lp8788_adc1",
> +		[LPADC_ADC2]      = "lp8788_adc2",
> +		[LPADC_ADC3]      = "lp8788_adc3",
> +		[LPADC_ADC4]      = "lp8788_adc4",
>  	};
>  
>  	if (!pdata)
> 

  reply	other threads:[~2012-10-19 17:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-18  6:11 [PATCH 2/3] lp8788-charger: fix ADC channel names Kim, Milo
2012-10-19 15:41 ` Jonathan Cameron [this message]
2012-10-22  0:23   ` Kim, Milo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50817497.5070900@kernel.org \
    --to=jic23@kernel.org \
    --cc=Milo.Kim@ti.com \
    --cc=anton.vorontsov@linaro.org \
    --cc=cbou@mail.ru \
    --cc=lars@metafoo.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.