From: Chien-Hua Yen <chien.yen@oracle.com>
To: xen-devel@lists.xen.org
Subject: Why guest is disallowed to change mask bit
Date: Fri, 19 Oct 2012 11:45:23 -0700 [thread overview]
Message-ID: <50819FC3.5050308@oracle.com> (raw)
Hi,
I am curious to know why Xen disallows guest to change the mask bit of
MSI-X
vector control as show in the comment out section in msixtbl_write().
Our SR-IOV driver got driver reload failure because it cannot enable
interrupt.
/* Do not allow the mask bit to be changed. */
#if 0 /* XXX
* As the mask bit is the only defined bit in the word, and as the
* host MSI-X code doesn't preserve the other bits anyway, doing
* this is pointless. So for now just discard the write (also
* saving us from having to determine the matching irq_desc).
*/
spin_lock_irqsave(&desc->lock, flags);
orig = readl(virt);
val &= ~PCI_MSIX_VECTOR_BITMASK;
val |= orig & PCI_MSIX_VECTOR_BITMASK;
writel(val, virt);
spin_unlock_irqrestore(&desc->lock, flags);
#endif
r = X86EMUL_OKAY;
Thanks.
Chien
next reply other threads:[~2012-10-19 18:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 18:45 Chien-Hua Yen [this message]
2012-10-22 9:04 ` Why guest is disallowed to change mask bit Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50819FC3.5050308@oracle.com \
--to=chien.yen@oracle.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.