From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Peres Subject: Re: Linux 3.7-rc1 (nouveau_bios_score oops). Date: Sat, 20 Oct 2012 00:41:48 +0200 Message-ID: <5081D72C.2080309@labri.fr> References: <1724445.dN2yMEzN6d@localhost> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------000404090404050608050405" Return-path: Received: from iona.labri.fr (iona.labri.fr [147.210.8.143]) by gabe.freedesktop.org (Postfix) with ESMTP id E15D39ECA9 for ; Fri, 19 Oct 2012 15:58:12 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Linus Torvalds Cc: =?UTF-8?B?UGF3ZcWCIFNpa29yYQ==?= , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Ben Skeggs , marcheu@chromium.org List-Id: dri-devel@lists.freedesktop.org This is a multi-part message in MIME format. --------------000404090404050608050405 Content-Type: multipart/alternative; boundary="------------020001070208050503050602" --------------020001070208050503050602 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 10/19/12 23:25, Linus Torvalds wrote: > Added more appropriate people to this. Added both i915 and nouveau > people, since apparently that fine piece of hardware has both. > > Guys, any ideas? > > Pawe=C5=82, could you perhaps get a photo of the oops and post it > somewhere? I'm assuming the oops happens early during boot and you > never get a usable machine with dmesg - but if you do, then please do > post the whole dmesg too. > > Linus Hi Linus, You must have missed the oops that was attached to the mail:=20 http://www.spinics.net/lists/kernel/msg1420355.html Pawe=C5=82, could you try the attached patch please ? Martin --------------020001070208050503050602 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On 10/19/12 23:25, Linus Torvalds wrote:
Added more appropriate people to this. Added both i9=
15 and nouveau
people, since apparently that fine piece of hardware has both.

Guys, any ideas?

Pawe=C5=82, could you perhaps get a photo of the oops and post it
somewhere? I'm assuming the oops happens early during boot and you
never get a usable machine with dmesg - but if you do, then please do
post the whole dmesg too.

              Linus
Hi Linus,

You must have missed the oops that was attached to the mail: http:= //www.spinics.net/lists/kernel/msg1420355.html

Pawe=C5=82, could you try the attached patch please ?

Martin

--------------020001070208050503050602-- --------------000404090404050608050405 Content-Type: text/x-patch; name="0001-drm-nouveau-bios-improve-error-handling-when-reading.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-drm-nouveau-bios-improve-error-handling-when-reading.pa"; filename*1="tch" >>From ea15dc1cf87236da78e8e88ecc3864ffab006ae0 Mon Sep 17 00:00:00 2001 From: Martin Peres Date: Sat, 20 Oct 2012 00:08:15 +0200 Subject: [PATCH] drm/nouveau/bios: improve error handling when reading the vbios from ACPI Reported-by: Pawel Sikora Signed-off-by: Martin Peres --- drivers/gpu/drm/nouveau/core/subdev/bios/base.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/core/subdev/bios/base.c b/drivers/gpu/drm/nouveau/core/subdev/bios/base.c index 2fbb6df..e31d8fc 100644 --- a/drivers/gpu/drm/nouveau/core/subdev/bios/base.c +++ b/drivers/gpu/drm/nouveau/core/subdev/bios/base.c @@ -188,8 +188,10 @@ nouveau_bios_shadow_acpi(struct nouveau_bios *bios) int cnt = 65536 / 4096; int ret; - if (!nouveau_acpi_rom_supported(pdev)) + if (!nouveau_acpi_rom_supported(pdev)) { + bios->data = NULL; return; + } bios->data = kmalloc(65536, GFP_KERNEL); bios->size = 0; -- 1.7.12.3 --------------000404090404050608050405 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --------------000404090404050608050405--