From mboxrd@z Thu Jan  1 00:00:00 1970
From: Clemens Ladisch <clemens@ladisch.de>
Subject: Re: usb-audio: Reloop Play support (TI TUSB3200AC)
Date: Sat, 20 Oct 2012 18:15:10 +0200
Message-ID: <5082CE0E.1010701@ladisch.de>
References: <1350652166.5549.8.camel@didier-laptop>
 <1350743458.25322.16.camel@didier-laptop>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by alsa0.perex.cz (Postfix) with ESMTP id EB9EE264F45
 for <alsa-devel@alsa-project.org>; Sat, 20 Oct 2012 18:16:28 +0200 (CEST)
In-Reply-To: <1350743458.25322.16.camel@didier-laptop>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Didier 'Ptitjes' Villevalois <ptitjes@free.fr>
Cc: alsa-devel@alsa-project.org, Daniel Mack <zonque@gmail.com>
List-Id: alsa-devel@alsa-project.org

Didier 'Ptitjes' Villevalois wrote:
>                 .vendor_name = "Reloop",
>                 .product_name = "Play",

These aren't needed except when they are wrong in the descriptor.

>                                 .data = &(const struct audioformat) {
>                                         .formats = SNDRV_PCM_FMTBIT_S24_3LE,
>                                         .channels = 4,
>                                         .iface = 1,
>                                         .altsetting = 1,
>                                         .altset_idx = 1,
>                                         .attributes = UAC_EP_CS_ATTR_SAMPLE_RATE,
>                                         .endpoint = 0x01,

You might as well set ep_attr to USB_ENDPOINT_SYNC_ADAPTIVE.


Regards,
Clemens