From: Richard Henderson <rth@twiddle.net>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] tcg/i386: remove ld/st third argument register constraint
Date: Sun, 21 Oct 2012 16:42:15 +1000 [thread overview]
Message-ID: <50839947.3080809@twiddle.net> (raw)
In-Reply-To: <1350754131-18667-2-git-send-email-aurelien@aurel32.net>
On 2012-10-21 03:28, Aurelien Jarno wrote:
> On x86_64, remove the constraint on the third argument register which
> is not needed:
> - For loads the helper arguments are env, addr, mem_idx. The addr
> value should not be in the two first argument registers as they are
> used in tcg_out_tlb_load().
> - For stores the helper arguments are env, addr, data, mem_idx.
> The addr and data values should not be in the two first argument
> registers as they are used in tcg_out_tlb_load(). The data value
> should also not be in the two first argument registers, but could
> be in the third argument register in which case it would be already
> loaded at the right location.
>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
next prev parent reply other threads:[~2012-10-21 6:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-20 17:28 [Qemu-devel] [PATCH 1/2] tcg/i386: remove suboptimal register shifting Aurelien Jarno
2012-10-20 17:28 ` [Qemu-devel] [PATCH 2/2] tcg/i386: remove ld/st third argument register constraint Aurelien Jarno
2012-10-21 6:42 ` Richard Henderson [this message]
2012-10-21 6:41 ` [Qemu-devel] [PATCH 1/2] tcg/i386: remove suboptimal register shifting Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50839947.3080809@twiddle.net \
--to=rth@twiddle.net \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.