All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jie Liu <jeff.liu@oracle.com>
To: "wenqing.lz" <gnehzuil.liu@gmail.com>
Cc: Zheng Liu <wenqing.lz@taobao.com>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: get return value in seek_sanity_test
Date: Sun, 21 Oct 2012 20:08:24 +0800	[thread overview]
Message-ID: <5083E5B8.8060304@oracle.com> (raw)
In-Reply-To: <1350819548-29634-1-git-send-email-wenqing.lz@taobao.com>

Hi Zheng,

On 10/21/12 19:39, wenqing.lz wrote:
> From: Zheng Liu <wenqing.lz@taobao.com>
>
> In seek_sanity_test getting return value is missing.  Thus we couldn't get the
> result unless someone read the log file (e.g. # 285).
>
> Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
> ---
>  src/seek_sanity_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/seek_sanity_test.c b/src/seek_sanity_test.c
> index 34f5508..e3ed64a 100644
> --- a/src/seek_sanity_test.c
> +++ b/src/seek_sanity_test.c
> @@ -676,7 +676,7 @@ int main(int argc, char **argv)
>  	for (i = 0; i < numtests; ++i) {
>  		if (ret)
>  			goto out;
> -		run_test(&seek_tests[i]);
> +		ret = run_test(&seek_tests[i]);
Thanks for the patch.
Looks there is another issue regarding the run_test loop, i.e, it should be:

    ret = run_test(&seek_tests[i]);
    if (ret)
        break;

Could you please fix it too?

Thanks,
-Jeff
>  	}
>  
>  out:

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2012-10-21 12:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-21 11:39 [PATCH] xfstests: get return value in seek_sanity_test wenqing.lz
2012-10-21 12:08 ` Jie Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5083E5B8.8060304@oracle.com \
    --to=jeff.liu@oracle.com \
    --cc=gnehzuil.liu@gmail.com \
    --cc=wenqing.lz@taobao.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.