All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Buck <jbbuck@gmail.com>
To: "ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>
Subject: Proposed change to vstart.sh
Date: Sun, 21 Oct 2012 14:31:58 -0700	[thread overview]
Message-ID: <508469CE.3000502@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 555 bytes --]

It looks like vstart.sh does not work without authx enabled. Given that, 
I'd propose to change the default to having cephx be enabled and then 
use the -x flag to disable cephx.

Interestingly enough, the help output for vstart.sh already states that 
the -x flag disables authx (which is not the case at present, but is 
after this patch is applied).

I've attached a patch to vstart that 1) changes the mention of authx to 
cephx for consistency and 2) defaults vstart.sh to using cephx with the 
-x flag now serving to disable cephx.

Best,
-Joe Buck

[-- Attachment #2: vstart.diff --]
[-- Type: text/x-patch, Size: 786 bytes --]

diff --git a/src/vstart.sh b/src/vstart.sh
index 7aaad49..b23b83a 100755
--- a/src/vstart.sh
+++ b/src/vstart.sh
@@ -21,7 +21,7 @@ ip=""
 nodaemon=0
 smallmds=0
 overwrite_conf=1
-cephx=0
+cephx=1 #turn cephx on by default
 
 MON_ADDR=""
 
@@ -43,7 +43,7 @@ usage=$usage"\t--nodaemon: use ceph-run as wrapper for mon/osd/mds\n"
 usage=$usage"\t--smallmds: limit mds cache size\n"
 usage=$usage"\t-m ip:port\t\tspecify monitor address\n"
 usage=$usage"\t-k keep old configuration files\n"
-usage=$usage"\t-x disable authx\n"
+usage=$usage"\t-x disable cephx\n"
 usage=$usage"\t-o config\t\t add extra config parameters to mds section\n"
 
 usage_exit() {
@@ -117,7 +117,7 @@ case $1 in
 	    shift
 	    ;;
     -x )
-	    cephx=1
+	    cephx=0
 	    ;;
     -k )
 	    overwrite_conf=0

             reply	other threads:[~2012-10-21 21:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-21 21:31 Joe Buck [this message]
2012-10-21 21:35 ` Proposed change to vstart.sh Sage Weil
2012-10-22  6:05   ` Dan Mick
2012-10-22 15:13   ` Joe Buck
2012-10-22 16:08     ` Sam Lang
2012-10-22 16:14       ` Yehuda Sadeh
2012-10-22 16:19         ` Sam Lang
2012-10-22 16:28           ` Yehuda Sadeh
2012-10-23 11:46             ` Sam Lang
2012-10-22 16:35       ` Joe Buck
2012-10-22 16:40         ` Sage Weil
2012-10-23  5:22           ` Dan Mick
2012-10-22 17:54         ` Sam Lang
2012-10-22 18:07           ` Joe Buck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=508469CE.3000502@gmail.com \
    --to=jbbuck@gmail.com \
    --cc=ceph-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.