From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59464) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQ8ur-0007a9-Bi for qemu-devel@nongnu.org; Sun, 21 Oct 2012 23:43:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQ8uq-000105-5r for qemu-devel@nongnu.org; Sun, 21 Oct 2012 23:43:01 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:57461) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQ8up-0000zx-W2 for qemu-devel@nongnu.org; Sun, 21 Oct 2012 23:43:00 -0400 Received: from eusync2.samsung.com (mailout3.w1.samsung.com [210.118.77.13]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MC9004E1ZODNH30@mailout3.w1.samsung.com> for qemu-devel@nongnu.org; Mon, 22 Oct 2012 04:43:25 +0100 (BST) Received: from [106.109.8.9] by eusync2.samsung.com (Oracle Communications Messaging Server 7u4-23.01(7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0MC900C2XZNLUZ70@eusync2.samsung.com> for qemu-devel@nongnu.org; Mon, 22 Oct 2012 04:42:58 +0100 (BST) Message-id: <5084C0C0.3030809@samsung.com> Date: Mon, 22 Oct 2012 07:42:56 +0400 From: Evgeny Voevodin MIME-version: 1.0 References: <1350650560-5362-1-git-send-email-e.voevodin@samsung.com> <1350650560-5362-6-git-send-email-e.voevodin@samsung.com> In-reply-to: Content-type: text/plain; charset=UTF-8; format=flowed Content-transfer-encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/6] TCG: Use gen_opparam_buf from context instead of global variable. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org, kyungmin.park@samsung.com, edgar.iglesias@gmail.com, aurelien@aurel32.net, rth@twiddle.net On 10/19/2012 09:53 PM, Blue Swirl wrote: > On Fri, Oct 19, 2012 at 12:42 PM, Evgeny wrote: >> Signed-off-by: Evgeny >> --- >> tcg/tcg.c | 10 +++++----- >> 1 file changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/tcg/tcg.c b/tcg/tcg.c >> index 3da1d83..77b15a0 100644 >> --- a/tcg/tcg.c >> +++ b/tcg/tcg.c >> @@ -302,7 +302,7 @@ void tcg_func_start(TCGContext *s) >> #endif >> >> s->gen_opc_ptr = s->gen_opc_buf; >> - s->gen_opparam_ptr = gen_opparam_buf; >> + s->gen_opparam_ptr = s->gen_opparam_buf; >> } >> >> static inline void tcg_temp_alloc(TCGContext *s, int n) >> @@ -889,7 +889,7 @@ void tcg_dump_ops(TCGContext *s) >> >> first_insn = 1; >> opc_ptr = s->gen_opc_buf; >> - args = gen_opparam_buf; >> + args = s->gen_opparam_buf; >> while (opc_ptr < s->gen_opc_ptr) { >> c = *opc_ptr++; >> def = &tcg_op_defs[c]; >> @@ -1413,7 +1413,7 @@ static void tcg_liveness_analysis(TCGContext *s) >> op_index--; >> } >> >> - if (args != gen_opparam_buf) >> + if (args != s->gen_opparam_buf) > Please add braces. Ok. Maybe I should introduce a little code clean-up in the scope of my patches? I mean, remove tabs and so on... Then maybe it would better be a separate patch? > >> tcg_abort(); >> } >> #else >> @@ -2108,7 +2108,7 @@ static inline int tcg_gen_code_common(TCGContext *s, uint8_t *gen_code_buf, >> >> #ifdef USE_TCG_OPTIMIZATIONS >> s->gen_opparam_ptr = >> - tcg_optimize(s, s->gen_opc_ptr, gen_opparam_buf, tcg_op_defs); >> + tcg_optimize(s, s->gen_opc_ptr, s->gen_opparam_buf, tcg_op_defs); >> #endif >> >> #ifdef CONFIG_PROFILER >> @@ -2135,7 +2135,7 @@ static inline int tcg_gen_code_common(TCGContext *s, uint8_t *gen_code_buf, >> s->code_buf = gen_code_buf; >> s->code_ptr = gen_code_buf; >> >> - args = gen_opparam_buf; >> + args = s->gen_opparam_buf; >> op_index = 0; >> >> for(;;) { >> -- >> 1.7.9.5 >> -- Kind regards, Evgeny Voevodin, Technical Leader, Mobile Group, Samsung Moscow Research Center, e-mail: e.voevodin@samsung.com