All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Yufei Ren <yufei.ren@stonybrook.edu>
Cc: fio@vger.kernel.org, Yufei Ren <renyufei83@gmail.com>
Subject: Re: [PATCH 3/4] rdma ioengine improvement
Date: Mon, 22 Oct 2012 10:06:35 +0200	[thread overview]
Message-ID: <5084FE8B.6090608@kernel.dk> (raw)
In-Reply-To: <1350702712-5168-4-git-send-email-yufei.ren@stonybrook.edu>

On 2012-10-20 05:11, Yufei Ren wrote:
> From: Yufei Ren <renyufei83@gmail.com>

This one needs a bit of explaining. What is the point of using a
re-entrant variant of rand(), if you are using a shared static variable
anyway?

Would it be better to use the fio shipped rand, now we're in there
anyway?

> @@ -790,6 +792,13 @@ static int fio_rdmaio_connect(struct thread_data *td, struct fio_file *f)
>  	/* wait for remote MR info from server side */
>  	rdma_poll_wait(td, IBV_WC_RECV);
>  
> +	/* In SEND/RECV test, iodepth in RECV side is deeper
> +	 * in SEND side. RECV needs more time to construct the
> +	 * buffer blocks, so the server side may need to stop
> +	 * some time before transfer data.
> +	 */
> +	usleep(500000);
> +
>  	return 0;

Hmm?

-- 
Jens Axboe


  reply	other threads:[~2012-10-22  8:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-20  3:11 [PATCH 0/4] FIO libnuma integration and 3 patches Yufei Ren
2012-10-20  3:11 ` [PATCH 1/4] cpuio engine cpuload bug fix Yufei Ren
2012-10-22  8:03   ` Jens Axboe
2012-10-20  3:11 ` [PATCH 2/4] thread cpu resource statistics " Yufei Ren
2012-10-22  8:04   ` Jens Axboe
2012-10-22 16:33     ` Yufei Ren
2012-10-22 17:10       ` Jens Axboe
2012-10-20  3:11 ` [PATCH 3/4] rdma ioengine improvement Yufei Ren
2012-10-22  8:06   ` Jens Axboe [this message]
2012-10-22 18:39     ` Yufei Ren
2012-10-20  3:11 ` [PATCH 4/4] Fine-grained job level numa control Yufei Ren
2012-10-22  8:07   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5084FE8B.6090608@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=fio@vger.kernel.org \
    --cc=renyufei83@gmail.com \
    --cc=yufei.ren@stonybrook.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.