Re: [Qemu-devel] [PATCH] main: Hide F_GETFD and FD_CLOEXEC use for _WIN32

[Corey Bryant <coreyb@linux.vnet.ibm.com>]

On 10/22/2012 12:16 PM, Luiz Capitulino wrote:
> On Mon, 22 Oct 2012 09:53:44 -0400
> Corey Bryant <coreyb@linux.vnet.ibm.com> wrote:
>
>>
>> Signed-off-by: Corey Bryant <coreyb@linux.vnet.ibm.com>
>> ---
>>   vl.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/vl.c b/vl.c
>> index 200d849..94c667d 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -812,11 +812,13 @@ static int parse_add_fd(QemuOpts *opts, void *opaque)
>>           return -1;
>>       }
>>
>> +#ifndef _WIN32
>>       if (fcntl(fd, F_GETFD) & FD_CLOEXEC) {
>>           qerror_report(ERROR_CLASS_GENERIC_ERROR,
>>                         "fd is not valid or already in use");
>>           return -1;
>>       }
>> +#endif
>
> Which series is this from? The command-line support for fd sets?
>
> qerror_report() is deprecated.
>

Kevin, please let me know if you want me to fix this.  Otherwise I 
assume you'll modify the v5 patch.

>>
>>       if (fdset_id < 0) {
>>           qerror_report(ERROR_CLASS_GENERIC_ERROR,
>

-- 
Regards,
Corey Bryant