From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: reserve pins when states are activated
Date: Mon, 22 Oct 2012 14:11:47 -0600 [thread overview]
Message-ID: <5085A883.9010803@wwwdotorg.org> (raw)
In-Reply-To: <1350893718-12336-1-git-send-email-linus.walleij@stericsson.com>
On 10/22/2012 02:15 AM, Linus Walleij wrote:
> This switches the way that pins are reserved for multiplexing:
>
> We used to do this when the map was parsed, at the creation of
> the settings inside the pinctrl handle, in pinmux_map_to_setting().
>
> However this does not work for us, because we want to use the
> same set of pins with different devices at different times: the
> diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c
> void pinmux_free_setting(struct pinctrl_setting const *setting)
...
> + /* This function is currently unused */
Being picky: It's not unused; it is used by pinctrl_put_locked(), but
just doesn't have to do anything given the implementation of
pinmux_map_to_setting().
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Linus Walleij <linus.walleij@stericsson.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Stephen Warren <swarren@nvidia.com>,
Anmar Oueja <anmar.oueja@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Patrice Chotard <patrice.chotard@st.com>,
Loic Pallardy <loic.pallardy@st.com>
Subject: Re: [PATCH] pinctrl: reserve pins when states are activated
Date: Mon, 22 Oct 2012 14:11:47 -0600 [thread overview]
Message-ID: <5085A883.9010803@wwwdotorg.org> (raw)
In-Reply-To: <1350893718-12336-1-git-send-email-linus.walleij@stericsson.com>
On 10/22/2012 02:15 AM, Linus Walleij wrote:
> This switches the way that pins are reserved for multiplexing:
>
> We used to do this when the map was parsed, at the creation of
> the settings inside the pinctrl handle, in pinmux_map_to_setting().
>
> However this does not work for us, because we want to use the
> same set of pins with different devices at different times: the
> diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c
> void pinmux_free_setting(struct pinctrl_setting const *setting)
...
> + /* This function is currently unused */
Being picky: It's not unused; it is used by pinctrl_put_locked(), but
just doesn't have to do anything given the implementation of
pinmux_map_to_setting().
next prev parent reply other threads:[~2012-10-22 20:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 8:15 [PATCH] pinctrl: reserve pins when states are activated Linus Walleij
2012-10-22 8:15 ` Linus Walleij
2012-10-22 20:11 ` Stephen Warren [this message]
2012-10-22 20:11 ` Stephen Warren
-- strict thread matches above, loose matches on Subject: below --
2012-10-18 10:01 Linus Walleij
2012-10-18 10:01 ` Linus Walleij
2012-10-18 23:33 ` Stephen Warren
2012-10-18 23:33 ` Stephen Warren
2012-10-19 12:51 ` Linus Walleij
2012-10-19 12:51 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5085A883.9010803@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.