From: Frank Rowand <frank.rowand@am.sony.com>
To: Bhavesh Davda <bhavesh@vmware.com>
Cc: "linux-rt-users@vger.kernel.org" <linux-rt-users@vger.kernel.org>,
John Kacur <jkacur@redhat.com>,
"Rowand, Frank" <Frank_Rowand@sonyusa.com>
Subject: Re: [PATCH RT-TESTS] cyclictest: whitespace cleanup
Date: Mon, 22 Oct 2012 18:12:58 -0700 [thread overview]
Message-ID: <5085EF1A.7060503@am.sony.com> (raw)
In-Reply-To: <F285BDD9-9A4A-4B58-B69F-90F18B9D7B4D@vmware.com>
On 10/16/12 09:39, Bhavesh Davda wrote:
> From: Bhavesh Davda <bhavesh@vmware.com>
>
> Cosmetic whitespace cleanup
>
> Signed-off-by: Bhavesh Davda <bhavesh@vmware.com>
>From checkpatch:
ERROR: code indent should use tabs where possible
#161: FILE: src/cyclictest/cyclictest.c:1419:
+ printf(fmt, index, stat->tid, par->prio,$
WARNING: please, no spaces at the start of a line
#161: FILE: src/cyclictest/cyclictest.c:1419:
+ printf(fmt, index, stat->tid, par->prio,$
total: 1 errors, 1 warnings, 140 lines checked
You did not add leading white space - it was already there and your
noble effort to remove the trailing white space led to this line
getting caught by checkpatch. Anyway, it is a good practice to
be checkpatch clean, even it rt-tests are not the linux kernel.
-Frank
next prev parent reply other threads:[~2012-10-23 1:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 16:39 [PATCH RT-TESTS] cyclictest: whitespace cleanup Bhavesh Davda
2012-10-23 1:12 ` Frank Rowand [this message]
2012-10-25 21:26 ` Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5085EF1A.7060503@am.sony.com \
--to=frank.rowand@am.sony.com \
--cc=Frank_Rowand@sonyusa.com \
--cc=bhavesh@vmware.com \
--cc=jkacur@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.