From: "Yan, Zheng" <zheng.z.yan@intel.com>
To: Stephane Eranian <eranian@google.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
LKML <linux-kernel@vger.kernel.org>,
"ak@linux.intel.com" <ak@linux.intel.com>
Subject: Re: [PATCH 1/6] perf, x86: Basic Haswell LBR call stack support
Date: Tue, 23 Oct 2012 13:31:01 +0800 [thread overview]
Message-ID: <50862B95.4020105@intel.com> (raw)
In-Reply-To: <CABPqkBQ8XCwONGvoXpu8kwwwcFPM9yJce4r9OJU4E7iY0_9ZUA@mail.gmail.com>
On 10/22/2012 07:23 PM, Stephane Eranian wrote:
> On Mon, Oct 22, 2012 at 12:33 PM, Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
>>
>> On Mon, 2012-10-22 at 14:11 +0800, Yan, Zheng wrote:
>>> + /* LBR callstack does not work well with FREEZE_LBRS_ON_PMI */
>>> + if (!cpuc->lbr_sel || !(cpuc->lbr_sel->config & LBR_CALL_STACK))
>>> + debugctl |= DEBUGCTLMSR_FREEZE_LBRS_ON_PMI;
>>
> Is this a bug or a feature?
>
It's a hardware bug. If FREEZE_LBRS_ON_PMI is set, PMI may corrupt the call stack records.
Regards
Yan, Zheng
>>
>> How useful it is without this? How many calls between PMI and us getting
>> to intel_pmu_lbr_read()?
>
> Agreed with Peter. Freeze on PMI is critical for LBR in general.
>
next prev parent reply other threads:[~2012-10-23 5:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 6:11 [PATCH 0/6] perf, x86: Haswell LBR call stack support Yan, Zheng
2012-10-22 6:11 ` [PATCH 1/6] perf, x86: Basic " Yan, Zheng
2012-10-22 10:33 ` Peter Zijlstra
2012-10-22 11:23 ` Stephane Eranian
2012-10-23 5:31 ` Yan, Zheng [this message]
2012-10-22 13:45 ` Andi Kleen
2012-10-23 5:28 ` Yan, Zheng
2012-10-22 10:35 ` Peter Zijlstra
2012-10-22 13:49 ` Andi Kleen
2012-10-23 5:41 ` Yan, Zheng
2012-10-23 10:11 ` Peter Zijlstra
2012-10-23 12:09 ` Stephane Eranian
2012-10-23 16:34 ` Andi Kleen
2012-10-22 6:11 ` [PATCH 2/6] perf, x86: Introduce x86 special perf event context Yan, Zheng
2012-10-22 6:11 ` [PATCH 3/6] perf, x86: Save/resotre LBR stack during context switch Yan, Zheng
2012-10-22 6:11 ` [PATCH 4/6] perf, core: Pass perf_sample_data to perf_callchain() Yan, Zheng
2012-10-22 6:11 ` [PATCH 5/6] perf, x86: Use LBR call stack to get user callchain Yan, Zheng
2012-10-22 6:11 ` [PATCH 6/6] perf, x86: Discard zero length call entries in LBR call stack Yan, Zheng
-- strict thread matches above, loose matches on Subject: below --
2012-10-22 5:57 [PATCH 0/6] perf, x86: Haswell LBR call stack support Yan, Zheng
2012-10-22 5:57 ` [PATCH 1/6] perf, x86: Basic " Yan, Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50862B95.4020105@intel.com \
--to=zheng.z.yan@intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.