Re: [PATCH] mm: cma: alloc_contig_range: return early for err path

[Ni zhan Chen <nizhan.chen@gmail.com>]

On 10/23/2012 02:45 PM, Bob Liu wrote:
> If start_isolate_page_range() failed, unset_migratetype_isolate() has been
> done inside it.
>
> Signed-off-by: Bob Liu <lliubbo@gmail.com>
> ---
>   mm/page_alloc.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index bb90971..b0012ab 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -5825,7 +5825,7 @@ int alloc_contig_range(unsigned long start, unsigned long end,
>   	ret = start_isolate_page_range(pfn_max_align_down(start),
>   				       pfn_max_align_up(end), migratetype);
>   	if (ret)
> -		goto done;
> +		return ret;

looks reasonable to me.

>   
>   	ret = __alloc_contig_migrate_range(&cc, start, end);
>   	if (ret)

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>