From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx194.postini.com [74.125.245.194]) by kanga.kvack.org (Postfix) with SMTP id 8F8B46B005A for ; Tue, 23 Oct 2012 09:41:10 -0400 (EDT) Message-ID: <50869E6C.1080907@redhat.com> Date: Tue, 23 Oct 2012 09:41:00 -0400 From: Rik van Riel MIME-Version: 1.0 Subject: Re: [PATCH RFC] mm/swap: automatic tuning for swapin readahead References: <50460CED.6060006@redhat.com> <20120906110836.22423.17638.stgit@zurg> <506AACAC.2010609@openvz.org> <506DB816.9090107@openvz.org> <20121016005049.GA1467@kernel.org> <20121022073654.GA7821@kernel.org> <20121023055127.GA24239@kernel.org> In-Reply-To: <20121023055127.GA24239@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Shaohua Li Cc: Hugh Dickins , Konstantin Khlebnikov , Minchan Kim , Andrew Morton , Wu Fengguang , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" On 10/23/2012 01:51 AM, Shaohua Li wrote: > I have no strong point against the global state method. But I'd agree making the > heuristic simple is preferred currently. I'm happy about the patch if the '+1' > is removed. Without the +1, how will you figure out when to re-enable readahead? -- All rights reversed -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932986Ab2JWNlS (ORCPT ); Tue, 23 Oct 2012 09:41:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42707 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932638Ab2JWNlR (ORCPT ); Tue, 23 Oct 2012 09:41:17 -0400 Message-ID: <50869E6C.1080907@redhat.com> Date: Tue, 23 Oct 2012 09:41:00 -0400 From: Rik van Riel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120827 Thunderbird/15.0 MIME-Version: 1.0 To: Shaohua Li CC: Hugh Dickins , Konstantin Khlebnikov , Minchan Kim , Andrew Morton , Wu Fengguang , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" Subject: Re: [PATCH RFC] mm/swap: automatic tuning for swapin readahead References: <50460CED.6060006@redhat.com> <20120906110836.22423.17638.stgit@zurg> <506AACAC.2010609@openvz.org> <506DB816.9090107@openvz.org> <20121016005049.GA1467@kernel.org> <20121022073654.GA7821@kernel.org> <20121023055127.GA24239@kernel.org> In-Reply-To: <20121023055127.GA24239@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/23/2012 01:51 AM, Shaohua Li wrote: > I have no strong point against the global state method. But I'd agree making the > heuristic simple is preferred currently. I'm happy about the patch if the '+1' > is removed. Without the +1, how will you figure out when to re-enable readahead? -- All rights reversed