From: Paolo Bonzini <pbonzini@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Blue Swirl <blauwirbel@gmail.com>, Avi Kivity <avi@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Rename target_phys_addr_t to hwaddr
Date: Tue, 23 Oct 2012 16:06:23 +0200 [thread overview]
Message-ID: <5086A45F.8000608@redhat.com> (raw)
In-Reply-To: <878vaxs5z4.fsf@codemonkey.ws>
Il 23/10/2012 14:55, Anthony Liguori ha scritto:
>> > target_phys_addr_t is unwieldly, violates the C standard (_t suffixes are
>> > reserved) and its purpose doesn't match the name (most target_phys_addr_t
>> > addresses are not target specific). Replace it with a finger-friendly,
>> > standards conformant hwaddr.
>> >
>> > Outstanding patchsets can be fixed up with the command
>> >
>> > git rebase -i --exec 'find -name "*.[ch]"
>> > | xargs s/target_phys_addr_t/hwaddr/g' origin
> We're getting pretty close to soft freeze so perhaps it's time to make a
> couple big changes.
>
> Paolo, are you ready to do the file rename changes? I'd like to
> coordinate this change with that one and do it all at the same time.
BTW,
$ git diffstat -M20 -C20 -l1500 --find-copies-harder origin/master.. | tail -1
1084 files changed, 4120 insertions(+), 5692 deletions(-)
(mostly due to moving around the include files, which is scripted).
$ git format-series -M20 -C20 -l1500 --find-copies-harder origin/master.. | wc -l
35346
Paolo
next prev parent reply other threads:[~2012-10-23 14:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 10:30 [Qemu-devel] [PATCH] Rename target_phys_addr_t to hwaddr Avi Kivity
2012-10-23 12:55 ` Anthony Liguori
2012-10-23 12:59 ` Paolo Bonzini
2012-10-23 14:06 ` Paolo Bonzini [this message]
2012-10-23 14:52 ` Avi Kivity
2012-10-23 13:04 ` Peter Maydell
2012-10-23 14:50 ` Avi Kivity
2012-10-23 18:11 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5086A45F.8000608@redhat.com \
--to=pbonzini@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.