From: Steve Dickson <SteveD@redhat.com>
To: Jim Rees <rees@umich.edu>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] Added more compile warning options
Date: Tue, 23 Oct 2012 10:45:08 -0400 [thread overview]
Message-ID: <5086AD74.4070905@RedHat.com> (raw)
In-Reply-To: <20121022214332.GA14793@umich.edu>
Hey Jim,
On 22/10/12 17:43, Jim Rees wrote:
> Steve Dickson wrote:
>
> To ensure the code compiles cleaner, the following warning options
> are now set
> -Wall -Wextra -Wstrict-prototypes -Wstrict-aliasing
> -Wconversion -Wsign-conversion -Wmissing-prototypes
> -Wsign-conversion -pedantic -Wmissing-prototypes
>
> You only need to specify them once. You've got sign-conversion and
> missing-prototypes twice.
Yeah... I noticed that after I posted the patch... This was more
of an RFC patch than anything... I just wanted to get people's opinion...
> Also I think -pedantic is going too far.
Why? The one patch its used for does the following:
-gss_OID g_mechOid = GSS_C_NULL_OID;;
+gss_OID g_mechOid = GSS_C_NULL_OID;
Which seems reasonable... What do you see that I don't?
steved.
prev parent reply other threads:[~2012-10-23 14:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 21:00 [PATCH] Added more compile warning options Steve Dickson
2012-10-22 21:43 ` Jim Rees
2012-10-23 14:45 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5086AD74.4070905@RedHat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=rees@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.