From: Larry Finger <Larry.Finger@lwfinger.net>
To: b43-dev@lists.infradead.org
Subject: b43 driver NULL pointer dereference on 3.4.15
Date: Tue, 23 Oct 2012 09:53:01 -0500 [thread overview]
Message-ID: <5086AF4D.5070404@lwfinger.net> (raw)
In-Reply-To: <50861EE6.70902@gmx.eu>
On 10/22/2012 11:36 PM, Markus Kanet wrote:
> NULL pointer dereference when unloading the b43 driver (not b43legacy) during
> shutdown if firmware was never loaded. See attached syslog.
When I did the b43legacy patch, it seemed reasonable that b43 also needed a
similar fix, but I could not get b43 to fail on two different systems. Does the
patch below work for you?
Larry
Index: wireless-testing-new/drivers/net/wireless/b43/main.c
===================================================================
--- wireless-testing-new.orig/drivers/net/wireless/b43/main.c
+++ wireless-testing-new/drivers/net/wireless/b43/main.c
@@ -5404,6 +5404,8 @@ static void b43_bcma_remove(struct bcma_
cancel_work_sync(&wldev->restart_work);
B43_WARN_ON(!wl);
+ if (!wldev->fw.ucode.data)
+ return; /* NULL if firmware never loaded */
if (wl->current_dev == wldev && wl->hw_registred) {
b43_leds_stop(wldev);
ieee80211_unregister_hw(wl->hw);
next prev parent reply other threads:[~2012-10-23 14:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 4:36 b43 driver NULL pointer dereference on 3.4.15 Markus Kanet
2012-10-23 14:53 ` Larry Finger [this message]
2012-10-23 19:10 ` Markus Kanet
2012-10-23 19:47 ` Larry Finger
2012-10-24 3:21 ` Markus Kanet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5086AF4D.5070404@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.