From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joao Eduardo Luis Subject: Re: running without cephx Date: Tue, 23 Oct 2012 21:51:11 +0100 Message-ID: <5087033F.4050802@inktank.com> References: <5086FAC1.3030706@inktank.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f46.google.com ([74.125.83.46]:64637 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933407Ab2JWUvS (ORCPT ); Tue, 23 Oct 2012 16:51:18 -0400 Received: by mail-ee0-f46.google.com with SMTP id b15so1590158eek.19 for ; Tue, 23 Oct 2012 13:51:16 -0700 (PDT) In-Reply-To: Sender: ceph-devel-owner@vger.kernel.org List-ID: To: Yehuda Sadeh Cc: Dan Mick , ceph-devel On 10/23/2012 09:24 PM, Yehuda Sadeh wrote: > On Tue, Oct 23, 2012 at 1:22 PM, Yehuda Sadeh wrote: >> On Tue, Oct 23, 2012 at 1:14 PM, Dan Mick wrote: >>> So, I've discovered that to make "no cephx" work, you need to explicitly set >>> "none" for the three options (thanks to Yehuda for the tip): >>> >>> auth cluster required = none >>> auth service required = none >>> auth supported = none >>> >>> Since "blank" is not an error, but leads to a disagreement about >>> authentication that's fairly hard to diagnose, should we make it an error to >>> specify a blank entry for those items? >>> >> Maybe fix it so that blank entries would be equivalent to 'none'? >> >> Yehuda > > That should do it: > > diff --git a/src/auth/AuthMethodList.cc b/src/auth/AuthMethodList.cc > index e23ac40..53c8d66 100644 > --- a/src/auth/AuthMethodList.cc > +++ b/src/auth/AuthMethodList.cc > @@ -35,6 +35,8 @@ AuthMethodList::AuthMethodList(CephContext *cct, string str) > lderr(cct) << "WARNING: unknown auth protocol defined: " << > *iter << dendl; > } > } > + if (auth_supported.empty()) > + auth_supported.push_back(CEPH_AUTH_NONE); > } > > bool AuthMethodList::is_supported_auth(int auth_type) I, for one, believe that when it comes to configuration files, leaving blank values defaulting to something is not the best idea. I would rather have a blank value spitting out an error, as it gives room for someone leaving it blank assuming it will use 'none', as others may assume it will default to 'cephx'. -Joao