From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58509)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <yeongkyoon.lee@samsung.com>) id 1TQrNG-0001k4-UL
	for qemu-devel@nongnu.org; Tue, 23 Oct 2012 23:11:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <yeongkyoon.lee@samsung.com>) id 1TQrNF-0000Zz-W2
	for qemu-devel@nongnu.org; Tue, 23 Oct 2012 23:11:18 -0400
Received: from mailout1.samsung.com ([203.254.224.24]:65158)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <yeongkyoon.lee@samsung.com>) id 1TQrNF-0000ZY-Ki
	for qemu-devel@nongnu.org; Tue, 23 Oct 2012 23:11:17 -0400
Received: from epcpsbgm2.samsung.com (epcpsbgm2 [203.254.230.27])
	by mailout1.samsung.com
	(Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit
	(built Nov
	17 2011)) with ESMTP id <0MCD00GNRNI2Y680@mailout1.samsung.com> for
	qemu-devel@nongnu.org; Wed, 24 Oct 2012 12:11:13 +0900 (KST)
Received: from [172.21.111.108] ([182.198.1.3])
	by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01
	(7.0.4.24.0) 64bit (built Nov 17 2011))
	with ESMTPA id <0MCD00K97NIOTJA0@mmp2.samsung.com> for
	qemu-devel@nongnu.org; Wed, 24 Oct 2012 12:11:12 +0900 (KST)
Date: Wed, 24 Oct 2012 12:11:23 +0900
From: Yeongkyoon Lee <yeongkyoon.lee@samsung.com>
In-reply-to: <20121023152546.GA53620@cs.nctu.edu.tw>
Message-id: <50875C5B.8080008@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=UTF-8; format=flowed
Content-transfer-encoding: QUOTED-PRINTABLE
References: <1350716743-2812-1-git-send-email-yeongkyoon.lee@samsung.com>
	<1350716743-2812-3-git-send-email-yeongkyoon.lee@samsung.com>
	<20121023152546.GA53620@cs.nctu.edu.tw>
Subject: Re: [Qemu-devel] [RESEND PATCH v6 2/3] tcg: Add extended GETPC
 mechanism for MMU helpers with ldst optimization
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?IumZs+mfi+S7uyAoV2VpLVJlbiBDaGVuKSI=?= <chenwj@iis.sinica.edu.tw>
Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org, aurelien@aurel32.net, rth@twiddle.net

On 2012=EB=85=84 10=EC=9B=94 24=EC=9D=BC 00:25, =E9=99=B3=E9=9F=8B=
=E4=BB=BB (Wei-Ren Chen) wrote:
> Hi Yeongkyoon,
>
>> +#if defined(CONFIG_QEMU_LDST_OPTIMIZATION) && defined(CONFIG_SOFT=
MMU)
>> +/* check whether the give addr is in TCG generated code buffer or=
 not */
>                          ^^^^
>
>    should be given.
>
> Cheers,
> chenwj
>

Thanks a lot, Wei-Ren.
Probably I should send the next version of the patch.