From: Johannes Sixt <j.sixt@viscovery.net>
To: Jeff King <peff@peff.net>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Git Mailing List" <git@vger.kernel.org>,
"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH 1/8] t1300: style updates
Date: Wed, 24 Oct 2012 08:33:15 +0200 [thread overview]
Message-ID: <50878BAB.60809@viscovery.net> (raw)
In-Reply-To: <20121023223554.GA17392@sigill.intra.peff.net>
Am 10/24/2012 0:35, schrieb Jeff King:
> -test_expect_success 'non-match value' \
> - 'test wow = $(git config --get nextsection.nonewline !for)'
> +test_expect_success 'non-match value' '
> + test wow = $(git config --get nextsection.nonewline !for)
> +'
Here's a case you forgot to update to test_cmp.
> +test_expect_success 'get-regexp variable with no value' '
> + git config --get-regexp novalue > output &&
> + test_cmp expect output'
And while you are here, you might want to remove this extra space. ;)
Otherwise, looks fine.
-- Hannes
next prev parent reply other threads:[~2012-10-24 6:33 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 15:55 The config include mechanism doesn't allow for overwriting Ævar Arnfjörð Bjarmason
2012-10-22 21:15 ` Jeff King
2012-10-23 14:13 ` Ævar Arnfjörð Bjarmason
2012-10-23 22:35 ` [PATCH 0/8] fix git-config with duplicate variable entries Jeff King
2012-10-23 22:35 ` [PATCH 1/8] t1300: style updates Jeff King
2012-10-24 6:33 ` Johannes Sixt [this message]
2012-10-24 6:37 ` Jeff King
2012-10-24 7:07 ` [PATCHv2 " Jeff King
2012-10-23 22:36 ` [PATCH 2/8] t1300: remove redundant test Jeff King
2012-10-23 22:36 ` [PATCH 3/8] t1300: test "git config --get-all" more thoroughly Jeff King
2012-10-23 22:36 ` [PATCH 4/8] git-config: remove memory leak of key regexp Jeff King
2012-10-23 22:38 ` [PATCH 5/8] git-config: fix regexp memory leaks on error conditions Jeff King
2012-10-23 22:40 ` [PATCH 6/8] git-config: collect values instead of immediately printing Jeff King
2012-10-23 22:41 ` [PATCH 7/8] git-config: do not complain about duplicate entries Jeff King
2012-10-23 22:41 ` [PATCH 8/8] git-config: use git_config_with_options Jeff King
2012-10-24 6:33 ` Johannes Sixt
2012-10-24 19:14 ` Ævar Arnfjörð Bjarmason
2012-11-20 19:08 ` [PATCH 0/8] fix git-config with duplicate variable entries Junio C Hamano
2012-11-21 19:27 ` Jeff King
2012-11-21 19:46 ` Junio C Hamano
2012-11-21 20:06 ` Jeff King
2012-11-21 20:42 ` Junio C Hamano
2012-11-23 10:37 ` Joachim Schmitz
2012-10-24 0:46 ` The config include mechanism doesn't allow for overwriting John Szakmeister
2012-10-24 0:51 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50878BAB.60809@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.