From: Mike Christie <michaelc@cs.wisc.edu>
To: John Soni Jose <sony.john-n@Emulex.Com>
Cc: linux-scsi@vger.kernel.org,
Jayamohan Kallickal <jayamohan.kallickal@Emulex.Com>
Subject: Re: [PATCH v2 17/19] be2iscsi: Fix for MBX timeout issue
Date: Wed, 24 Oct 2012 01:45:36 -0500 [thread overview]
Message-ID: <50878E90.1000800@cs.wisc.edu> (raw)
In-Reply-To: <fc49c9f1-3026-472d-9dfb-bf256bc95627@CMEXHTCAS1.ad.emulex.com>
On 10/19/2012 06:15 PM, John Soni Jose wrote:
> @@ -763,26 +750,14 @@ static int beiscsi_get_port_speed(struct Scsi_Host *shost)
> "BS_%d : Getting Port Speed Failed\n");
>
> return -EBUSY;
> - } else
> - wait_event_interruptible(phba->ctrl.mcc_wait[tag],
> - phba->ctrl.mcc_numtag[tag]);
> -
> - wrb_num = (phba->ctrl.mcc_numtag[tag] & 0x00FF0000) >> 16;
> - extd_status = (phba->ctrl.mcc_numtag[tag] & 0x0000FF00) >> 8;
> - status = phba->ctrl.mcc_numtag[tag] & 0x000000FF;
> -
> - if (status || extd_status) {
> + }
> + rc = beiscsi_mccq_compl(phba, tag, &wrb, NULL);
> + if (rc) {
> beiscsi_log(phba, KERN_ERR,
There was some small whitespace issues in this patch. Maybe James will
fix it up when it is merged. I do not know why checkpatch.pl and git did
not warn about them.
next prev parent reply other threads:[~2012-10-24 6:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 23:15 [PATCH v2 17/19] be2iscsi: Fix for MBX timeout issue John Soni Jose
2012-10-24 6:45 ` Mike Christie [this message]
2012-11-13 21:34 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50878E90.1000800@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=jayamohan.kallickal@Emulex.Com \
--cc=linux-scsi@vger.kernel.org \
--cc=sony.john-n@Emulex.Com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.