From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: libxl: build error Date: Wed, 24 Oct 2012 12:50:59 +0200 Message-ID: <5087C813.8090609@amd.com> References: <5087B6A4.6030203@amd.com> <1351072711.2237.139.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------010607020908010407060506" Return-path: In-Reply-To: <1351072711.2237.139.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org --------------010607020908010407060506 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On 10/24/12 11:58, Ian Campbell wrote: > On Wed, 2012-10-24 at 10:36 +0100, Christoph Egger wrote: >> Hi, >> >> I have this build error: >> >> xl_cmdimpl.c:3724:40: error: declaration of 'reboot' shadows a global >> declaration > > Did gcc tell you where the other global definition was from? No. > reboot(2) I suppose? Yes. has the prototype. >> Renaming it to '_reboot' fixes this for me. > > Can you send a patch? > > I don't think _reboot is a legal identifier (reserved for the > implementation or POSIX or some such). do_reboot would be ok. So would > changing main_shutdown_or_reboot to take the function pointer directly I > think. patch attached. Signed-off-by: Christoph Egger Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85689 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 --------------010607020908010407060506 Content-Type: text/plain; charset="us-ascii"; name="xen_tools_libxl.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="xen_tools_libxl.diff" Content-Description: xen_tools_libxl.diff ZGlmZiAtciBhYzg3MGRmNGYxNjUgdG9vbHMvbGlieGwveGxfY21kaW1wbC5jCi0tLSBhL3Rv b2xzL2xpYnhsL3hsX2NtZGltcGwuYwlXZWQgT2N0IDI0IDA5OjUwOjUyIDIwMTIgKzAyMDAK KysrIGIvdG9vbHMvbGlieGwveGxfY21kaW1wbC5jCVdlZCBPY3QgMjQgMTE6MTk6NTkgMjAx MiArMDIwMApAQCAtMzcyMSwxMSArMzcyMSwxMSBAQCBpbnQgbWFpbl9kZXN0cm95KGludCBh cmdjLCBjaGFyICoqYXJndikKICAgICByZXR1cm4gMDsKIH0KIAotc3RhdGljIGludCBtYWlu X3NodXRkb3duX29yX3JlYm9vdChpbnQgcmVib290LCBpbnQgYXJnYywgY2hhciAqKmFyZ3Yp CitzdGF0aWMgaW50IG1haW5fc2h1dGRvd25fb3JfcmVib290KGludCBkb19yZWJvb3QsIGlu dCBhcmdjLCBjaGFyICoqYXJndikKIHsKICAgICB2b2lkICgqZm4pKHVpbnQzMl90IGRvbWlk LAogICAgICAgICAgICAgICAgbGlieGxfZXZnZW5fZG9tYWluX2RlYXRoICoqLCBsaWJ4bF9l dl91c2VyLCBpbnQpID0KLSAgICAgICAgcmVib290ID8gJnJlYm9vdF9kb21haW4gOiAmc2h1 dGRvd25fZG9tYWluOworICAgICAgICBkb19yZWJvb3QgPyAmcmVib290X2RvbWFpbiA6ICZz aHV0ZG93bl9kb21haW47CiAgICAgaW50IG9wdCwgaSwgbmJfZG9tYWluOwogICAgIGludCB3 YWl0X2Zvcl9pdCA9IDAsIGFsbCA9MDsKICAgICBpbnQgZmFsbGJhY2tfdHJpZ2dlciA9IDA7 Cg== --------------010607020908010407060506 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --------------010607020908010407060506--