From: Paolo Bonzini <pbonzini@redhat.com>
To: Corey Bryant <coreyb@linux.vnet.ibm.com>
Cc: pmoore@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org,
Eduardo Otubo <otubo@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 4/4] Warning messages on net devices hotplug
Date: Wed, 24 Oct 2012 17:21:47 +0200 [thread overview]
Message-ID: <5088078B.3070002@redhat.com> (raw)
In-Reply-To: <5087F899.2030604@linux.vnet.ibm.com>
Il 24/10/2012 16:18, Corey Bryant ha scritto:
>
>
> On 10/18/2012 11:15 AM, Paolo Bonzini wrote:
>> Il 17/10/2012 15:15, Eduardo Otubo ha scritto:
>>> With the inclusion of the new "double whitelist" seccomp filter, Qemu
>>> won't be able to execve() in runtime, thus, no hotplug net devices
>>> allowed.
>>>
>>> Signed-off-by: Eduardo Otubo <otubo@linux.vnet.ibm.com>
>>
>> Please check this in net_init_tap instead. When using libvirt, hotplug
>> is done with a completely different mechanism that involves
>> file-descriptor passing and does not require executing a helper.
>>
>> Paolo
>>
>
> Are you sure net_init_tap() is the right place for this check?
Yes, assuming there is a global that says whether the seccomp sandbox is
in effect. Even something like "if (sandbox_active && !tap->has_fd)
error(...)" can be enough.
Paolo
next prev parent reply other threads:[~2012-10-24 15:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 13:15 [Qemu-devel] [PATCH 1/4] Adding new syscalls (bugzilla 855162) Eduardo Otubo
2012-10-17 13:15 ` [Qemu-devel] [PATCH 2/4] Setting "-sandbox on" as deafult Eduardo Otubo
2012-10-18 15:08 ` Corey Bryant
2012-10-17 13:15 ` [Qemu-devel] [PATCH 3/4] Support for "double whitelist" filters Eduardo Otubo
2012-10-19 17:04 ` Blue Swirl
2012-10-19 20:08 ` Corey Bryant
2012-10-19 20:36 ` Eric Blake
2012-10-19 20:46 ` Corey Bryant
2012-10-19 20:03 ` Corey Bryant
2012-10-17 13:15 ` [Qemu-devel] [PATCH 4/4] Warning messages on net devices hotplug Eduardo Otubo
2012-10-18 14:59 ` Corey Bryant
2012-10-18 15:15 ` Paolo Bonzini
2012-10-24 14:18 ` Corey Bryant
2012-10-24 14:34 ` Corey Bryant
2012-10-24 15:21 ` Paolo Bonzini [this message]
2012-10-24 15:39 ` Corey Bryant
2012-10-24 15:45 ` Paolo Bonzini
2012-10-24 15:56 ` Corey Bryant
2012-10-24 17:30 ` Corey Bryant
2012-10-25 7:40 ` Paolo Bonzini
2012-10-26 14:14 ` Corey Bryant
2012-10-19 19:58 ` [Qemu-devel] [PATCH 1/4] Adding new syscalls (bugzilla 855162) Corey Bryant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5088078B.3070002@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=coreyb@linux.vnet.ibm.com \
--cc=otubo@linux.vnet.ibm.com \
--cc=pmoore@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.