From mboxrd@z Thu Jan 1 00:00:00 1970 From: walter harms Date: Wed, 24 Oct 2012 16:17:05 +0000 Subject: Re: [PATCH] drivers/gpu/drm/radeon/evergreen_cs.c: Remove unnecessary semicolon Message-Id: <50881481.90302@bfs.de> List-Id: References: <1351089746-5552-1-git-send-email-peter.senna@gmail.com> In-Reply-To: <1351089746-5552-1-git-send-email-peter.senna@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kernel-janitors@vger.kernel.org Am 24.10.2012 16:42, schrieb Peter Senna Tschudin: > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // > @r1@ > statement S; > position p,p1; > @@ > S@p1;@p > > @script:python r2@ > p << r1.p; > p1 << r1.p1; > @@ > if p[0].line != p1[0].line_end: > cocci.include_match(False) > @@ > position r1.p; > @@ > -;@p > // > > Signed-off-by: Peter Senna Tschudin > > --- > > The full version of the semantic patch can be found at: > http://www.mail-archive.com/cocci@systeme.lip6.fr/msg00014.html > > drivers/gpu/drm/radeon/evergreen_cs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/radeon/evergreen_cs.c b/drivers/gpu/drm/radeon/evergreen_cs.c > index 573ed1b..5daf0c5 100644 > --- a/drivers/gpu/drm/radeon/evergreen_cs.c > +++ b/drivers/gpu/drm/radeon/evergreen_cs.c > @@ -264,7 +264,7 @@ static int evergreen_surface_check_2d(struct radeon_cs_parser *p, > /* macro tile width & height */ > palign = (8 * surf->bankw * track->npipes) * surf->mtilea; > halign = (8 * surf->bankh * surf->nbanks) / surf->mtilea; > - mtileb = (palign / 8) * (halign / 8) * tileb;; > + mtileb = (palign / 8) * (halign / 8) * tileb; mmh, that can be reduced to: mtileb = surf->bankw * track->npipes * surf->bankh * surf->nbanks * tileb; is this an improvement ? It look less complicated that the original one. re, wh > mtile_pr = surf->nbx / palign; > mtile_ps = (mtile_pr * surf->nby) / halign; > surf->layer_size = mtile_ps * mtileb * slice_pt;