From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:46969)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TR4d9-0005LE-4Q
	for qemu-devel@nongnu.org; Wed, 24 Oct 2012 13:20:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TR4d3-0001sy-4r
	for qemu-devel@nongnu.org; Wed, 24 Oct 2012 13:20:35 -0400
Message-ID: <5088234F.5050303@suse.de>
Date: Wed, 24 Oct 2012 19:20:15 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1345488308-10410-1-git-send-email-brogers@suse.com>
	<CAFEAcA83KM8tMuT3_dtqvmvLKRi-upmR_B6XyPACsS5DF_nr1Q@mail.gmail.com>
In-Reply-To: <CAFEAcA83KM8tMuT3_dtqvmvLKRi-upmR_B6XyPACsS5DF_nr1Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] configure: avoid compiler warning in pipe2
 detection
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-stable@nongnu.org, qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>, Bruce Rogers <brogers@suse.com>, Aurelien Jarno <aurelien@aurel32.net>

Am 24.10.2012 18:48, schrieb Peter Maydell:
> Ping! Just ran into this bug today and noticed this
> patch never got applied.
> Patch still applies OK, patchwork url is:
> http://patchwork.ozlabs.org/patch/178920/

...and since it was noticed while packaging v1.2, it should go into
stable as well (cc'ed).

Andreas

> On 20 August 2012 19:45, Bruce Rogers <brogers@suse.com> wrote:
>> When building qemu-kvm for openSUSE:Factory, I am getting a
>> warning in the pipe2 detection performed by configure, which
>> prevents using --enable-werror.
>>
>> Change detection code to use return value of pipe2.
>>
>> Signed-off-by: Bruce Rogers <brogers@suse.com>
>> ---
>>  configure |    3 +--
>>  1 files changed, 1 insertions(+), 2 deletions(-)
>>
>> diff --git a/configure b/configure
>> index 5808764..2e1f7f8 100755
>> --- a/configure
>> +++ b/configure
>> @@ -2399,8 +2399,7 @@ cat > $TMPC << EOF
>>  int main(void)
>>  {
>>      int pipefd[2];
>> -    pipe2(pipefd, O_CLOEXEC);
>> -    return 0;
>> +    return pipe2(pipefd, O_CLOEXEC);
>>  }
>>  EOF
>>  if compile_prog "" "" ; then
>> --
>> 1.7.7

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg