From mboxrd@z Thu Jan  1 00:00:00 1970
Content-Type: multipart/mixed; boundary="===============3325548768596139034=="
MIME-Version: 1.0
From: Chris Ferron <chris.e.ferron at linux.intel.com>
Subject: Re: [Powertop] [PATCH] Enable asserts and make correct comment
Date: Wed, 24 Oct 2012 10:37:29 -0700
Message-ID: <50882759.6020603@linux.intel.com>
In-Reply-To: 1349953133-17076-1-git-send-email-i.zhbanov@samsung.com
To: powertop@lists.01.org
List-ID: <powertop@lists.01.org>

--===============3325548768596139034==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

On 10/11/2012 03:58 AM, Igor Zhbanov wrote:
> Enable asserts for test period and correct the comments.
> It is better to know why a crash happen when it could happen
> than just silently die.
> ---
>   src/report/report-formatter-base.cpp |    3 ++-
>   src/report/report-formatter-csv.cpp  |    3 ++-
>   src/report/report-formatter-html.cpp |    3 ++-
>   src/report/report-maker.cpp          |    3 ++-
>   4 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/src/report/report-formatter-base.cpp b/src/report/report-for=
matter-base.cpp
> index 4b448be..e0dc49c 100644
> --- a/src/report/report-formatter-base.cpp
> +++ b/src/report/report-formatter-base.cpp
> @@ -25,7 +25,8 @@
>   =

>   #define _BSD_SOURCE
>   =

> -#define NDEBUG /* Enable asserts */
> +/* Uncomment to disable asserts */
> +/*#define NDEBUG*/
>   =

>   #include <stdio.h>
>   #include <assert.h>
> diff --git a/src/report/report-formatter-csv.cpp b/src/report/report-form=
atter-csv.cpp
> index 9b154b5..cd70d91 100644
> --- a/src/report/report-formatter-csv.cpp
> +++ b/src/report/report-formatter-csv.cpp
> @@ -25,7 +25,8 @@
>   =

>   #define _BSD_SOURCE
>   =

> -#define NDEBUG /* Enable asserts */
> +/* Uncomment to disable asserts */
> +/*#define NDEBUG*/
>   =

>   #include <stdio.h>
>   #include <assert.h>
> diff --git a/src/report/report-formatter-html.cpp b/src/report/report-for=
matter-html.cpp
> index 56f9648..5851575 100644
> --- a/src/report/report-formatter-html.cpp
> +++ b/src/report/report-formatter-html.cpp
> @@ -25,7 +25,8 @@
>   =

>   #define _BSD_SOURCE
>   =

> -#define NDEBUG /* Enable asserts */
> +/* Uncomment to disable asserts */
> +/*#define NDEBUG*/
>   =

>   #include <stdio.h>
>   #include <assert.h>
> diff --git a/src/report/report-maker.cpp b/src/report/report-maker.cpp
> index 4a68a8c..c00c955 100644
> --- a/src/report/report-maker.cpp
> +++ b/src/report/report-maker.cpp
> @@ -23,7 +23,8 @@
>    * Written by Igor Zhbanov <i.zhbanov(a)samsung.com>
>    * 2012.10 */
>   =

> -#define NDEBUG /* Enable asserts */
> +/* Uncomment to disable asserts */
> +/*#define NDEBUG*/
>   =

>   #include <assert.h>
>   #include <stdarg.h>
Your patch as been merged.
Thank You
-C


--===============3325548768596139034==--