From: Rich Johnston <rjohnston@sgi.com>
To: Tomas Racek <tracek@redhat.com>
Cc: "Lukáš Czerner" <lczerner@redhat.com>, xfs@oss.sgi.com
Subject: Re: [PATCH v3] xfstests: Use upstream version of fstrim instead of the local one
Date: Wed, 24 Oct 2012 15:51:53 -0500 [thread overview]
Message-ID: <508854E9.7010809@sgi.com> (raw)
In-Reply-To: <241834517.1979252.1349381614990.JavaMail.root@redhat.com>
Thomas,
On 10/04/2012 03:13 PM, Tomas Racek wrote:
> ----- Original Message -----
>> On Thu, 4 Oct 2012, Tomas Racek wrote:
>>
>> Ok, so the reason is to strip the variable mount point from the
>> error message. It sounds ok than.
>>
>> This makes me think that we maybe want to have a filter function to
>> filter out all the variables such as SCRATCH_MNT, SCRATCH_DEV,
>> TEST_DIR,
>> TEST_DEV and maybe more and replace then with the some appropriate
>> strings
>> (SCRATCH_MNT etc. maybe?). I am sure more tests can benefit from this
>> not
>> needing to to the filtering on their own.
>
> Oh, thanks for reminding me -- they already exist (see common.filter), I forgot about them. I will use them in next version. ;-)
>
>
> Tom
>
V4 has been committed to git://oss.sgi.com/xfs/cmds/xfstests, master branch.
Regards
--Rich
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2012-10-24 20:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-15 13:00 [PATCH v3] xfstests: Use upstream version of fstrim instead of the local one Tomas Racek
2012-10-02 14:32 ` Tomas Racek
2012-10-03 11:03 ` Lukáš Czerner
2012-10-04 8:47 ` Tomas Racek
2012-10-04 9:12 ` Lukáš Czerner
2012-10-04 20:13 ` Tomas Racek
2012-10-24 20:51 ` Rich Johnston [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508854E9.7010809@sgi.com \
--to=rjohnston@sgi.com \
--cc=lczerner@redhat.com \
--cc=tracek@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.