From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57495) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRAJT-0002Cf-2D for qemu-devel@nongnu.org; Wed, 24 Oct 2012 19:24:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TRAJR-0008Oe-LH for qemu-devel@nongnu.org; Wed, 24 Oct 2012 19:24:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7389) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRAJR-0008Oa-D1 for qemu-devel@nongnu.org; Wed, 24 Oct 2012 19:24:37 -0400 Message-ID: <508878B1.6030503@redhat.com> Date: Wed, 24 Oct 2012 17:24:33 -0600 From: Eric Blake MIME-Version: 1.0 References: <24E144B8C0207547AD09C467A8259F75576FED43@lisa.maurer-it.com> In-Reply-To: <24E144B8C0207547AD09C467A8259F75576FED43@lisa.maurer-it.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig6B4AF56072C2FE3C776E8F98" Subject: Re: [Qemu-devel] raltelimit bug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dietmar Maurer Cc: "pbonzini@redhat.com" , "qemu-devel@nongnu.org" This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig6B4AF56072C2FE3C776E8F98 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 10/24/2012 02:56 AM, Dietmar Maurer wrote: > The code to compute slice_quota seems buggy. The following fixes the is= sue: >=20 > --- new.orig/include/qemu/ratelimit.h 2012-10-22 07:06:31.000000000 += 0200 Missing a Signed-off-By, so it cannot be taken as-is. See http://wiki.qemu.org/Contribute/SubmitAPatch for hints. > +++ new/include/qemu/ratelimit.h 2012-10-22 07:06:49.000000000 += 0200 > @@ -42,7 +42,7 @@ > uint64_t slice_ns) > { > limit->slice_ns =3D slice_ns; > - limit->slice_quota =3D ((double)speed * 1000000000ULL) / slice_ns;= > + limit->slice_quota =3D ((double)speed * slice_ns)/1000000000ULL; > } > =20 > #endif >=20 >=20 >=20 >=20 --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig6B4AF56072C2FE3C776E8F98 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQiHiyAAoJEKeha0olJ0NqiZYH/2jiDx60tvDsLQbq546Sk0GJ Xb4YCFN9PKSMbIL2mel7gADZR/X/SirBLWa/vuUwtnDf7jSGYYSzHmp2fdR3m+1/ 13VQWVn5eagqEm5jInvUCtFPg9ohuPW7QV48mAskgbeZ4JUuWR4i1K175SiV+Jc0 jBU0Dg5SXKGNDXzmm0YTHNFQyva4hMGEnTKgkHjpgvOU8setA2Lai0F2Z23oJFQG 2T2h4fUMiPM3c8hGPR1xMuD7wWIzb5T1xatZFfI8VXufhaEFOA0NFInDp60Fm5Lb ZgO8Bv/vsWuCwQ97hyluosoyFq+blTdUutE5+eRpwC1Drcezx8LTIU2hez59BwY= =IWiY -----END PGP SIGNATURE----- --------------enig6B4AF56072C2FE3C776E8F98--