From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44197) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRHCY-0006jn-EB for qemu-devel@nongnu.org; Thu, 25 Oct 2012 02:45:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TRHCX-0005ib-6B for qemu-devel@nongnu.org; Thu, 25 Oct 2012 02:45:58 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:55960) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRHCW-0005iP-W7 for qemu-devel@nongnu.org; Thu, 25 Oct 2012 02:45:57 -0400 Received: from eusync4.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MCF00FALS533810@mailout1.w1.samsung.com> for qemu-devel@nongnu.org; Thu, 25 Oct 2012 07:46:15 +0100 (BST) Received: from [106.109.8.9] by eusync4.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MCF00F1XS4GAY90@eusync4.samsung.com> for qemu-devel@nongnu.org; Thu, 25 Oct 2012 07:45:53 +0100 (BST) Message-id: <5088E020.1000305@samsung.com> Date: Thu, 25 Oct 2012 10:45:52 +0400 From: Evgeny Voevodin MIME-version: 1.0 References: <1350973278-2236-1-git-send-email-e.voevodin@samsung.com> In-reply-to: <1350973278-2236-1-git-send-email-e.voevodin@samsung.com> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/7] TCG global variables clean-up List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Evgeny Voevodin , blauwirbel@gmail.com, kyungmin.park@samsung.com, edgar.iglesias@gmail.com, aurelien@aurel32.net, rth@twiddle.net Here are the results of tests before and after this patch series was applied: * EEMBC CoreMark (before -> after) - Guest: Exynos4210 ARMv7, Linux (Custom buildroot image) - Host: Intel(R) Core(TM) i5 CPU 750 @ 2.67GHz, 4GB RAM, Linux - Results: 1148.105626 -> 1161.440186 (+1.16%) * nbench (before -> after) - Guest: Exynos4210 ARMv7, Linux (Custom buildroot image) - Host: Intel(R) Core(TM) i5 CPU 750 @ 2.67GHz, 4GB RAM, Linux - Results . MEMORY INDEX: 1.864 -> 1.862 (-0.11%) . INTEGER INDEX: 2.518 -> 2.523 (+0.2%) . FLOATING-POINT INDEX: 0.385 -> 0.394 (+2.34%) Those tests show that it became even faster :)) But I'm quite sceptical about such results. The thing is that in case of nbench it prints the warning if results are not 95% statistically accurate. So we can be sure that nbench result is 95% accurate. And it's obvious that result shown above are in the scope of this accuracy. I don't know the accuracy of CoreMark. So, the main decision we can make that this patch series didn't introduce any slow-down comparable to inaccuracy of the measurement. Is this enough? On 10/23/2012 10:21 AM, Evgeny Voevodin wrote: > This set of patches moves global variables to tcg_ctx: > gen_opc_ptr > gen_opparam_ptr > gen_opc_buf > gen_opparam_buf > > Build tested for all targets. > Execution tested on ARM. > > I didn't notice any slow-down of kernel boot after this set was applied. > > Changelog: > v1->v2: > Introduced TCGContext *tcg_cur_ctx global to use in those places where we don't > have an interface to pass pointer to tcg_ctx. > Code style clean-up > > Evgeny (2): > tcg/tcg.h: Duplicate global TCG variables in TCGContext > TCG: Remove unused global variables > > Evgeny Voevodin (5): > translate-all.c: Introduce TCGContext *tcg_cur_ctx > TCG: Use gen_opc_ptr from context instead of global variable. > TCG: Use gen_opparam_ptr from context instead of global variable. > TCG: Use gen_opc_buf from context instead of global variable. > TCG: Use gen_opparam_buf from context instead of global variable. > > gen-icount.h | 2 +- > target-alpha/translate.c | 10 +- > target-arm/translate.c | 10 +- > target-cris/translate.c | 13 +- > target-i386/translate.c | 10 +- > target-lm32/translate.c | 13 +- > target-m68k/translate.c | 10 +- > target-microblaze/translate.c | 13 +- > target-mips/translate.c | 11 +- > target-openrisc/translate.c | 13 +- > target-ppc/translate.c | 11 +- > target-s390x/translate.c | 11 +- > target-sh4/translate.c | 10 +- > target-sparc/translate.c | 10 +- > target-unicore32/translate.c | 10 +- > target-xtensa/translate.c | 8 +- > tcg/optimize.c | 62 ++++---- > tcg/tcg-op.h | 324 ++++++++++++++++++++--------------------- > tcg/tcg.c | 85 ++++++----- > tcg/tcg.h | 11 +- > translate-all.c | 4 +- > 21 files changed, 328 insertions(+), 323 deletions(-) > -- Kind regards, Evgeny Voevodin, Technical Leader, Mobile Group, Samsung Moscow Research Center, e-mail: e.voevodin@samsung.com