All of lore.kernel.org
 help / color / mirror / Atom feed
From: Holger Brunck <holger.brunck@keymile.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Multiple stdin/out without CONFIG_CONSOLE_MUX?
Date: Thu, 25 Oct 2012 09:22:35 +0200	[thread overview]
Message-ID: <5088E8BB.70205@keymile.com> (raw)
In-Reply-To: <50887423.8060409@wwwdotorg.org>

Hi Stephen,

On 10/25/2012 01:05 AM, Stephen Warren wrote:
> 
> While looking into a CONFIG_CONSOLE_MUX-related issue, I noticed the
> following:
> 
> include/configs/u8500_href.h:136:	"stdin=serial,usbtty\0"
> include/configs/u8500_href.h:135:	"stdout=serial,usbtty\0"
> include/configs/snowball.h:180:	"stdout=serial,usbtty\0"
> 
> Those all include multiple devices in the stdin/stdout definitions.
> However, those config files don't set CONFIG_CONSOLE_MUX. I assume this
> causes usbtty to be ignored, and only serial used?
> 
> Or perhaps U-Boot even fails to parse the variable at all, since
> CONFIG_SYS_CONSOLE_IS_IN_ENV isn't set on those boards? Actually, there
> are a few more boards with that problem:
> 
>> include/configs/km/keymile-common.h:258:	"stdout=serial\0"						\
>> include/configs/MVBC_P.h:146:	"stdout=serial\0"					\
>> include/configs/MVBLM7.h:460:	"stdout=serial\0"					\
>> include/configs/MVSMR.h:129:	"stdout=serial\0"					\
>> include/configs/sandbox.h:91:					"stdout=serial\0" \
>> include/configs/snowball.h:180:	"stdout=serial,usbtty\0"					\
>> include/configs/u8500_href.h:135:	"stdout=serial,usbtty\0"					\

I actually didn't get the point whats the problem here, but you are right our
boards have stdin,stdout,stderr defined in their environment. It seems to be
unneeded here. Maybe it is caused because we used CONFIG_CONSOLE_MUX in the past
but the relevant code was dropped at some point.

So we can remove these variables from our boards completely. Thanks for pointing
out.

Regards
Holger

  reply	other threads:[~2012-10-25  7:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-24 23:05 [U-Boot] Multiple stdin/out without CONFIG_CONSOLE_MUX? Stephen Warren
2012-10-25  7:22 ` Holger Brunck [this message]
2012-10-26 11:59   ` Andre Schwarz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5088E8BB.70205@keymile.com \
    --to=holger.brunck@keymile.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.