From: Thomas Hellstrom <thellstrom@vmware.com>
To: Ilija Hadzic <ihadzic@research.bell-labs.com>,
Dave Airlie <airlied@redhat.com>
Cc: linux-graphics-maintainer@vmware.com,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Breakage in "track dev_mapping in more robust and flexible way"
Date: Thu, 25 Oct 2012 16:02:25 +0200 [thread overview]
Message-ID: <50894671.2070803@vmware.com> (raw)
Hi,
This commit
From 949c4a34afacfe800fc442afac117aba15284962 Mon Sep 17 00:00:00 2001
From: Ilija Hadzic <ihadzic@research.bell-labs.com>
Date: Tue, 15 May 2012 16:40:10 -0400
Subject: [PATCH] drm: track dev_mapping in more robust and flexible way
Setting dev_mapping (pointer to the address_space structure
used for memory mappings) to the address_space of the first
opener's inode and then failing if other openers come in
through a different inode has a few restrictions that are
eliminated by this patch.
If we already have valid dev_mapping and we spot an opener
with different i_node, we force its i_mapping pointer to the
already established address_space structure (first opener's
inode). This will make all mappings from drm device hang off
the same address_space object.
...
Breaks drivers using TTM, since when the X server calls into the driver
open, drm's dev_mapping has not
yet been setup. The setup needs to be moved before the driver's open
hook is called.
Typically, if a TTM-aware driver is provoked by the Xorg server to move
a buffer from system to VRAM or AGP,
before any other drm client is started, The user-space page table
entries are not killed before the move, and left pointing
into freed pages, causing system crashes and / or user-space access to
arbitrary memory.
/Thomas
next reply other threads:[~2012-10-25 14:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 14:02 Thomas Hellstrom [this message]
2012-10-25 14:41 ` Breakage in "track dev_mapping in more robust and flexible way" Jerome Glisse
2012-10-25 15:10 ` Thomas Hellström
2012-10-25 17:12 ` Ilija Hadzic
2012-10-25 17:31 ` Ilija Hadzic
2012-10-25 18:27 ` Thomas Hellström
2012-10-25 21:27 ` Ilija Hadzic
2012-10-26 8:11 ` Thomas Hellstrom
2012-10-26 13:14 ` Ilija Hadzic
2012-10-29 8:39 ` Thomas Hellstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50894671.2070803@vmware.com \
--to=thellstrom@vmware.com \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ihadzic@research.bell-labs.com \
--cc=linux-graphics-maintainer@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.