From: Steve Dickson <SteveD@redhat.com>
To: Jeff Layton <jlayton@redhat.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH v2 05/10] nfsdcltrack: add a new "one-shot" program for manipulating the client tracking db
Date: Thu, 25 Oct 2012 10:30:44 -0400 [thread overview]
Message-ID: <50894D14.9090101@RedHat.com> (raw)
In-Reply-To: <20121025095327.1d463b4c@corrin.poochiereds.net>
On 25/10/12 09:53, Jeff Layton wrote:
>> Is needs_arg really necessary? Once the function is found, just pass
>> > it the rest of argv and let the function decide if there should
>> > be an argument or not... but again.. just a nit...
>> >
>> > steved.
> No, it's not strictly necessary. The alternative though is to make the
> command functions do argv processing, which seemed more ugly to me. I
> tend to prefer to keep argv processing in a single place since it can
> get sort of hairy to work through the bounds checks after getopt and
> such.
>
> If you feel strongly about it, I can try to change it, but I don't
> think the result will be cleaner.
>
Like I said its a nit... Just a different way to look at it... no
issues here keeping it as is...
steved.
next prev parent reply other threads:[~2012-10-25 14:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 15:25 [PATCH v2 00/10] nfsdcltrack: create a new usermodehelper upcall program for tracking clients Jeff Layton
2012-10-24 15:25 ` [PATCH v2 01/10] nfsdcltrack: fix segfault in sqlite debug logging Jeff Layton
2012-10-24 15:25 ` [PATCH v2 02/10] nfsdcltrack: rename the nfsdcld directory and options to nfsdcltrack Jeff Layton
2012-10-24 15:25 ` [PATCH v2 03/10] nfsdcltrack: remove pointless sqlite_topdir variable Jeff Layton
2012-10-24 15:25 ` [PATCH v2 04/10] nfsdcltrack: break out a function to open the database handle Jeff Layton
2012-10-24 15:25 ` [PATCH v2 05/10] nfsdcltrack: add a new "one-shot" program for manipulating the client tracking db Jeff Layton
2012-10-25 12:56 ` Steve Dickson
2012-10-25 13:53 ` Jeff Layton
2012-10-25 14:30 ` Steve Dickson [this message]
2012-10-24 15:25 ` [PATCH v2 06/10] nfsdcltrack: add a legacy transition mechanism Jeff Layton
2012-10-24 15:25 ` [PATCH v2 07/10] nfsdcltrack: add a manpage for nfsdcltrack Jeff Layton
2012-10-24 15:25 ` [PATCH v2 08/10] nfsdcltrack: remove the nfsdcld daemon Jeff Layton
2012-10-24 15:25 ` [PATCH v2 09/10] nfsdcltrack: update the README about server startup order Jeff Layton
2012-10-24 15:25 ` [PATCH v2 10/10] nfsdcltrack: flip the default in autoconf to "yes" for it Jeff Layton
2012-10-25 12:57 ` Steve Dickson
2012-10-25 14:07 ` Jeff Layton
2012-10-25 14:28 ` Steve Dickson
2012-10-25 14:34 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50894D14.9090101@RedHat.com \
--to=steved@redhat.com \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.