Re: [Qemu-devel] [PATCH 1/4] qemu-char: Add new char backend CirMemCharDriver

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 933 bytes --]

On 10/25/2012 01:54 PM, Lei Li wrote:
> Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
> ---
>  qemu-char.c     |  136 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  qemu-config.c   |    3 +
>  qemu-options.hx |   10 ++++
>  3 files changed, 149 insertions(+), 0 deletions(-)
> 
>  
> +/*********************************************************/
> +/*CircularMemory chardev*/
> +

Better; I'll assume the other thread also title v5 was a mis-send.

> +Create a circular buffer with fixed size indicated by optionally @option{maxcapacity}
> +which will be default 64K if it is not given.
> +
> +@option{maxcapacity} specify the max capacity of the size of circular buffer
> +want to create. Should be power of 2.

Still, this grammar could be improved:

s/specify/specifies/
s/want//

-- 
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 617 bytes --]