From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:53145)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TRkfl-0001OD-65
	for qemu-devel@nongnu.org; Fri, 26 Oct 2012 10:14:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TRkfa-0007B8-7T
	for qemu-devel@nongnu.org; Fri, 26 Oct 2012 10:14:05 -0400
Received: from mail-bk0-f45.google.com ([209.85.214.45]:64906)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TRkfa-0007Aw-0T
	for qemu-devel@nongnu.org; Fri, 26 Oct 2012 10:13:54 -0400
Received: by mail-bk0-f45.google.com with SMTP id jf3so1092065bkc.4
	for <qemu-devel@nongnu.org>; Fri, 26 Oct 2012 07:13:53 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <508A9A9E.3090203@redhat.com>
Date: Fri, 26 Oct 2012 16:13:50 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <cover.1351248724.git.amit.shah@redhat.com>
In-Reply-To: <cover.1351248724.git.amit.shah@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/8] virtio-rng: hardware random number
	generator device
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu list <qemu-devel@nongnu.org>, Anthony Liguori <anthony@codemonkey.ws>

Il 26/10/2012 13:01, Amit Shah ha scritto:
> Amit Shah (1):
>   virtio-rng: hardware random number generator device
> 
> Anthony Liguori (7):
>   object: add object_property_add_bool (v2)
>   qdev: add realized property and make adding child bus implied by
>     realize
>   vl: add -object option to create QOM objects from the command line
>   vl: add -late-object to create QOM objects after machine init
>   rng: add RndBackend abstract object class
>   rng-urandom: add an RNG backend that uses /dev/urandom
>   rng-egd: introduce EGD compliant RNG backend

Honestly I think this is overengineered.

I would instead have the following:

- a chardev that can read from a file (e.g. -chardev
file,path=/dev/urandom,read=on,id=urandom)

- a device that accepts a chardev and understands both egd and raw (e.g.
-device virtio-rng-pci,chardev=urandom,egd=off or -device
virtio-rng-pci,chardev=egdsock,egd=on).

- optionally, a chardev that can produce an endless stream of data via
rdrand.

And that's it.

Also, even if RngBackend goes in, there is no need for -late-object
right now, so I would not include it in this series.

Paolo