From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] serial: remove calls to serial_assign()
Date: Fri, 26 Oct 2012 10:23:32 -0600 [thread overview]
Message-ID: <508AB904.1000801@wwwdotorg.org> (raw)
In-Reply-To: <CAPnjgZ2H7m_VTWeSjwSyWMMiDhy8N0teYeWKoqU9Muz6cm8WGw@mail.gmail.com>
On 10/26/2012 09:50 AM, Simon Glass wrote:
> Hi,
>
> On Fri, Oct 26, 2012 at 7:53 AM, Tom Rini <trini@ti.com> wrote: On
> 10/26/12 00:10, Marek Vasut wrote:
>>>> Dear Joe Hershberger,
>>>>
>>>>> Hi Allen,
>>>>>
>>>>> On Thu, Oct 25, 2012 at 6:30 PM, Allen Martin
>>>>> <amartin@nvidia.com> wrote:
>>>>>> Remove calls to serial_assign() that are failing now that
>>>>>> it returns a proper error code. This calls were not
>>>>>> actually doing anything because they passed the name of a
>>>>>> stdio_dev when a serial_device name is exptectd.
>>>>>>
>>>>>> Signed-off-by: Allen Martin <amartin@nvidia.com> ---
>>>>>
>>>>> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
>>>>
>>>> Acked-by: Marek Vasut <marex@denx.de>
>
> And this indeed fixes Tegra, right?
>
>> It fixes the serial hang we discussed. I think Tegra still has
>> the SPL problem that Stephen reported (the need for
>> serial_initialize()), or at least I haven't seen a patch for
>> that.
Allen posted 3 patches to rework Tegra's SPL:
tegra20: initialize variable to avoid compiler warning
tegra: move to common SPL framework
SPL: make jump_to_image_no_args a weak symbol
I also posted 5 patches to solve an oversized-SPL issue on Seaboard
and Ventana:
ARM: tegra: don't request GPIO from Seaboard's SPL
ARM: tegra: select between Seaboard/Ventana at compile time
ARM: tegra: derive CONFIG_SPL_MAX_SIZE instead of hard-coding it
ARM: enhance u-boot.lds to detect over-sized SPL
ARM: fix u-boot.lds for -ffunction-sections/-fdata-sections
I tested this current patch with all of those applied.
>> Tested on seaboard.
>
>> Acked-by: Simon Glass <sjg@chromium.org> Tested-by: Simon Glass
>> <sjg@chromium.org>
This patch,
Tested-by: Stephen Warren <swarren@nvidia.com>
next prev parent reply other threads:[~2012-10-26 16:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 23:30 [U-Boot] [PATCH] serial: remove calls to serial_assign() Allen Martin
2012-10-25 23:39 ` Joe Hershberger
2012-10-26 7:10 ` Marek Vasut
2012-10-26 14:53 ` Tom Rini
2012-10-26 15:50 ` Simon Glass
2012-10-26 16:23 ` Stephen Warren [this message]
2012-10-26 16:35 ` Simon Glass
2012-10-26 16:35 ` Tom Rini
2012-10-26 22:12 ` Tom Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508AB904.1000801@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.