Re: [Qemu-devel] [PATCH v2] stop using stdio for monitor/serial/etc with -daemonize

[Michael Tokarev <mjt@tls.msk.ru>]

On 27.10.2012 16:48, Blue Swirl wrote:
[]
>> I'd rather have -nographic work with -daemonize, since the
>> alternative - shown in the patch comment - is rather long and
>> it is easy to forget to "nullify" some option, while -nographic
>> can do that easy and it is convinient, but if people dislikes
>> such natural and easy-for-the-user solutions, I wont insist.
> 
> Instead of checking just for -nographic or -curses, can we forbid use
> of any stdio chardev?

I think that'll be quite a bit more difficult.  Sure, say,

  -serial stdio -daemonize

now has the same problem as original

  -nographic -daemonize.

It is just now after you mentioned it I realized this omission.
And it is exactly the same thing actually - we initialize
stdio for the serial port, in both cases, and it switches
the tty to raw mode.

So this patch is insufficient indeed, we still have the
same issue, and once -nographic -daemonize is disallowed,
we've much better chances to hit this issue using -serial.
Oh well.

Hmm.  Maybe init stdio chardev for something "else" in case
of -nographic?

[]
>> It is a real PITA that these rather trivial things require so much
>> discussing and stays known but unfixed for so long, and much more
>> important things gets less time and energy as the result.
> 
> Perfect is the enemy of good. It's also too easy to break things since
> the design features are not described and tested comprehensively.

Well, bugs aren't perfect or good, they're bad.  And any breakage
can be fixed once detected, it isn't like we've some very deep
dependencies with very distant and hidden effects -- I'm talking
about rather trivial things really.

Thanks,

/mjt