From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V3 5/5] ARM: tegra: don't request GPIO from Seaboard's SPL
Date: Sat, 27 Oct 2012 20:09:20 -0600 [thread overview]
Message-ID: <508C93D0.4060400@wwwdotorg.org> (raw)
In-Reply-To: <20121027111533.4b2e9bf1@lilith>
On 10/27/2012 03:15 AM, Albert ARIBAUD wrote:
> Hi Stephen,
>
> On Mon, 22 Oct 2012 10:19:36 -0600, Stephen Warren
> <swarren@wwwdotorg.org> wrote:
>
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> Seaboard has a GPIO that switches an external mux between Tegra's debug
>> UART and SPI flash. This is initialized from the SPL so that SPL debug
>> output can be seen. Simplify the code that does this, and don't actually
>> request the GPIO in the SPL; just program it. This saves ~4.5K from the
>> size of the SPL, mostly BSS due to the large gpio_names[] table that is
>> no longer required. This makes Seaboard's SPL fit within the current max
>> size.
>
> Is it possible to reorder the patch series so that Seaboard (and
> Ventana?) builds do not break temporarily between patch 2 and this
> patch?
It would be possibel, although I'd personally rather call out the issue
explicitly with a build break; if the build succeeds, you end up using
code that silently causes memory corruption. Of course, this issue has
been around for a while, so perhaps hiding it for another couple extra
commits wouldn't be a big deal. Plus, the build break proves the assert
in the .lds file works:-) But it's not big deal either way; feel free to
re-order the commits if you want.
next prev parent reply other threads:[~2012-10-28 2:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 16:19 [U-Boot] [PATCH V3 1/5] ARM: fix u-boot.lds for -ffunction-sections/-fdata-sections Stephen Warren
2012-10-22 16:19 ` [U-Boot] [PATCH V3 2/5] ARM: enhance u-boot.lds to detect over-sized SPL Stephen Warren
2012-10-22 17:52 ` Tom Rini
2012-10-25 18:11 ` Simon Glass
2012-10-22 16:19 ` [U-Boot] [PATCH V3 3/5] ARM: tegra: derive CONFIG_SPL_MAX_SIZE instead of hard-coding it Stephen Warren
2012-10-25 18:12 ` Simon Glass
2012-10-22 16:19 ` [U-Boot] [PATCH V3 4/5] ARM: tegra: select between Seaboard/Ventana at compile time Stephen Warren
2012-10-25 18:13 ` Simon Glass
2012-10-22 16:19 ` [U-Boot] [PATCH V3 5/5] ARM: tegra: don't request GPIO from Seaboard's SPL Stephen Warren
2012-10-25 18:15 ` Simon Glass
2012-10-27 9:15 ` Albert ARIBAUD
2012-10-28 2:09 ` Stephen Warren [this message]
2012-10-28 14:07 ` Albert ARIBAUD
2012-10-25 18:11 ` [U-Boot] [PATCH V3 1/5] ARM: fix u-boot.lds for -ffunction-sections/-fdata-sections Simon Glass
2012-10-26 21:45 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508C93D0.4060400@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.