From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: yegorslists@googlemail.com, linux-can@vger.kernel.org
Subject: Re: [PATCH] candump: add option to ignore ENOBUFS
Date: Sun, 28 Oct 2012 21:02:27 +0100 [thread overview]
Message-ID: <508D8F53.1050005@hartkopp.net> (raw)
In-Reply-To: <508A5C05.6050803@pengutronix.de>
On 26.10.2012 11:46, Marc Kleine-Budde wrote:
> On 10/26/2012 11:42 AM, yegorslists@googlemail.com wrote:
>> From: Yegor Yefremov <yegorslists@googlemail.com>
>>
>> -f option replicated -i option from cangen and allows to
>> ignore ENOBUFS error in bridge mode
>
> Better not ignore, but handle the error. If socket would support, wait
> with select/poll that the socket get writable and try again. For now
> sleep and try again. (or fix the poll/select bug in the kernel).
ACK.
IIRC this was a problem of socket write queue length that are too long to
handle short MTUs like we have with CAN frames.
Therefore the socket itself does not stop the traffic.
Definitely something to be fixed ... i'll take a look into the mails from
Michal Sojka.
Regards,
Oliver
next prev parent reply other threads:[~2012-10-28 19:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-26 9:42 [PATCH] candump: add option to ignore ENOBUFS yegorslists
2012-10-26 9:46 ` Marc Kleine-Budde
2012-10-28 20:02 ` Oliver Hartkopp [this message]
2012-10-29 8:00 ` Yegor Yefremov
2014-01-10 22:02 ` Oliver Hartkopp
2014-01-13 10:00 ` Yegor Yefremov
2014-01-13 18:15 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508D8F53.1050005@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=yegorslists@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.