From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
To: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Cc: git@adamspiers.org, Jeff King <peff@peff.net>,
GIT Mailing-list <git@vger.kernel.org>
Subject: [PATCH] pathspec.c: Fix some sparse warnings
Date: Sun, 28 Oct 2012 21:09:19 +0000 [thread overview]
Message-ID: <508D9EFF.3040900@ramsay1.demon.co.uk> (raw)
Sparse issues a warning for all six external symbols defined in this
file. In order to suppress the warnings, we include the 'pathspec.h'
header file, which contains the relevant extern declarations for these
symbols.
Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
Hi Nguyen,
I asked Adam to squash this patch into his 'as/check-ignore' branch
when he next re-rolled the branch. However, it appears that you
resubmitted that branch instead ... :-D
I don't know if this branch is ready to progress to next yet, but
could somebody (yourself, Adam or Jeff?) please squash this into
commit 1a88ae42 ("pathspec.c: move reusable code from builtin/add.c")
before it hits next.
Thanks!
ATB,
Ramsay Jones
pathspec.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/pathspec.c b/pathspec.c
index a9c5b5b..efdabe4 100644
--- a/pathspec.c
+++ b/pathspec.c
@@ -1,5 +1,6 @@
#include "cache.h"
#include "dir.h"
+#include "pathspec.h"
void validate_path(const char *prefix, const char *path)
{
--
1.8.0
next reply other threads:[~2012-10-28 21:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-28 21:09 Ramsay Jones [this message]
2012-10-28 23:31 ` [PATCH] pathspec.c: Fix some sparse warnings Adam Spiers
2012-10-29 5:55 ` Jeff King
-- strict thread matches above, loose matches on Subject: below --
2012-09-25 17:15 Ramsay Jones
2012-09-25 18:03 ` Adam Spiers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508D9EFF.3040900@ramsay1.demon.co.uk \
--to=ramsay@ramsay1.demon.co.uk \
--cc=git@adamspiers.org \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.