From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sekhar Nori Subject: Re: [RFC PATCH v3 11/16] mmc: omap_hsmmc: limit max_segs with the EDMA DMAC Date: Mon, 29 Oct 2012 13:48:46 +0530 Message-ID: <508E3BE6.3070609@ti.com> References: <1350566815-409-1-git-send-email-mporter@ti.com> <1350566815-409-12-git-send-email-mporter@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1350566815-409-12-git-send-email-mporter-l0cyMroinI0@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Matt Porter Cc: Linux DaVinci Kernel List , Linux OMAP List , Russell King , Linux Documentation List , Devicetree Discuss , Mark Brown , Linux MMC List , Linux Kernel Mailing List , Rob Herring , Vinod Koul , Dan Williams , Linux SPI Devel List , Chris Ball , Linux ARM Kernel List List-Id: linux-mmc@vger.kernel.org On 10/18/2012 6:56 PM, Matt Porter wrote: > The EDMA DMAC has a hardware limitation that prevents supporting > scatter gather lists with any number of segments. Since the EDMA > DMA Engine driver sets the maximum segments to 16, we do the > same. > > TODO: this will be replaced once the DMA Engine API supports an > API to query the DMAC's segment size limit. > > Signed-off-by: Matt Porter > --- > drivers/mmc/host/omap_hsmmc.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c > index b327cd0..52bab01 100644 > --- a/drivers/mmc/host/omap_hsmmc.c > +++ b/drivers/mmc/host/omap_hsmmc.c > @@ -1828,6 +1828,16 @@ static int __devinit omap_hsmmc_probe(struct platform_device *pdev) > * as we want. */ > mmc->max_segs = 1024; > > + /* Eventually we should get our max_segs limitation for EDMA by > + * querying the dmaengine API */ Nit picking: This is not as per multi-line comment style in Documentation/CodingStyle. Thanks, Sekhar From mboxrd@z Thu Jan 1 00:00:00 1970 From: nsekhar@ti.com (Sekhar Nori) Date: Mon, 29 Oct 2012 13:48:46 +0530 Subject: [RFC PATCH v3 11/16] mmc: omap_hsmmc: limit max_segs with the EDMA DMAC In-Reply-To: <1350566815-409-12-git-send-email-mporter@ti.com> References: <1350566815-409-1-git-send-email-mporter@ti.com> <1350566815-409-12-git-send-email-mporter@ti.com> Message-ID: <508E3BE6.3070609@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/18/2012 6:56 PM, Matt Porter wrote: > The EDMA DMAC has a hardware limitation that prevents supporting > scatter gather lists with any number of segments. Since the EDMA > DMA Engine driver sets the maximum segments to 16, we do the > same. > > TODO: this will be replaced once the DMA Engine API supports an > API to query the DMAC's segment size limit. > > Signed-off-by: Matt Porter > --- > drivers/mmc/host/omap_hsmmc.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c > index b327cd0..52bab01 100644 > --- a/drivers/mmc/host/omap_hsmmc.c > +++ b/drivers/mmc/host/omap_hsmmc.c > @@ -1828,6 +1828,16 @@ static int __devinit omap_hsmmc_probe(struct platform_device *pdev) > * as we want. */ > mmc->max_segs = 1024; > > + /* Eventually we should get our max_segs limitation for EDMA by > + * querying the dmaengine API */ Nit picking: This is not as per multi-line comment style in Documentation/CodingStyle. Thanks, Sekhar From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758013Ab2J2ITr (ORCPT ); Mon, 29 Oct 2012 04:19:47 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:50215 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755739Ab2J2ITo (ORCPT ); Mon, 29 Oct 2012 04:19:44 -0400 Message-ID: <508E3BE6.3070609@ti.com> Date: Mon, 29 Oct 2012 13:48:46 +0530 From: Sekhar Nori User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:16.0) Gecko/20121010 Thunderbird/16.0.1 MIME-Version: 1.0 To: Matt Porter CC: Tony Lindgren , Grant Likely , Mark Brown , Benoit Cousson , Russell King , Vinod Koul , Rob Landley , Chris Ball , Devicetree Discuss , Linux OMAP List , Linux ARM Kernel List , Linux DaVinci Kernel List , Linux Kernel Mailing List , Linux Documentation List , Linux MMC List , Linux SPI Devel List , Arnd Bergmann , Dan Williams , Rob Herring Subject: Re: [RFC PATCH v3 11/16] mmc: omap_hsmmc: limit max_segs with the EDMA DMAC References: <1350566815-409-1-git-send-email-mporter@ti.com> <1350566815-409-12-git-send-email-mporter@ti.com> In-Reply-To: <1350566815-409-12-git-send-email-mporter@ti.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/18/2012 6:56 PM, Matt Porter wrote: > The EDMA DMAC has a hardware limitation that prevents supporting > scatter gather lists with any number of segments. Since the EDMA > DMA Engine driver sets the maximum segments to 16, we do the > same. > > TODO: this will be replaced once the DMA Engine API supports an > API to query the DMAC's segment size limit. > > Signed-off-by: Matt Porter > --- > drivers/mmc/host/omap_hsmmc.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c > index b327cd0..52bab01 100644 > --- a/drivers/mmc/host/omap_hsmmc.c > +++ b/drivers/mmc/host/omap_hsmmc.c > @@ -1828,6 +1828,16 @@ static int __devinit omap_hsmmc_probe(struct platform_device *pdev) > * as we want. */ > mmc->max_segs = 1024; > > + /* Eventually we should get our max_segs limitation for EDMA by > + * querying the dmaengine API */ Nit picking: This is not as per multi-line comment style in Documentation/CodingStyle. Thanks, Sekhar