From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 1/3] drm/omap: add support for ARCH_MULTIPLATFORM Date: Mon, 29 Oct 2012 11:04:55 +0200 Message-ID: <508E46B7.3040306@ti.com> References: <1351499474-5937-1-git-send-email-rob.clark@linaro.org> <1351499474-5937-2-git-send-email-rob.clark@linaro.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1858773988==" Return-path: Received: from devils.ext.ti.com (devils.ext.ti.com [198.47.26.153]) by gabe.freedesktop.org (Postfix) with ESMTP id 48D429ED6E for ; Mon, 29 Oct 2012 02:10:07 -0700 (PDT) In-Reply-To: <1351499474-5937-2-git-send-email-rob.clark@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Rob Clark Cc: patches@linaro.org, Greg KH , dri-devel@lists.freedesktop.org, Rob Clark List-Id: dri-devel@lists.freedesktop.org --===============1858773988== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig1393AC961346839DB481BDCD" --------------enig1393AC961346839DB481BDCD Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2012-10-29 10:31, Rob Clark wrote: > From: Rob Clark >=20 > Remove usage of plat/cpu.h and get information from platform data > instead. This enables omapdrm to be built with ARCH_MULTIPLATFORM. >=20 > Signed-off-by: Rob Clark > --- > arch/arm/mach-omap2/drm.c | 7 +++++++ > drivers/staging/omapdrm/Kconfig | 2 +- > drivers/staging/omapdrm/omap_dmm_tiler.h | 1 - > drivers/staging/omapdrm/omap_drv.c | 6 +++++- > drivers/staging/omapdrm/omap_drv.h | 2 ++ > include/linux/platform_data/omap_drm.h | 1 + > 6 files changed, 16 insertions(+), 3 deletions(-) >=20 > diff --git a/arch/arm/mach-omap2/drm.c b/arch/arm/mach-omap2/drm.c > index 72e0f01b..49a7ffb 100644 > --- a/arch/arm/mach-omap2/drm.c > +++ b/arch/arm/mach-omap2/drm.c > @@ -23,15 +23,20 @@ > #include > #include > #include > +#include > =20 > #include > #include > +#include > =20 > #if defined(CONFIG_DRM_OMAP) || (CONFIG_DRM_OMAP_MODULE) > =20 > +static struct omap_drm_platform_data platform_data; > + > static struct platform_device omap_drm_device =3D { > .dev =3D { > .coherent_dma_mask =3D DMA_BIT_MASK(32), > + .platform_data =3D &platform_data, > }, > .name =3D "omapdrm", > .id =3D 0, > @@ -52,6 +57,8 @@ static int __init omap_init_drm(void) > oh->name); > } > =20 > + platform_data.omaprev =3D GET_OMAP_REVISION(); > + > return platform_device_register(&omap_drm_device); > =20 > } > diff --git a/drivers/staging/omapdrm/Kconfig b/drivers/staging/omapdrm/= Kconfig > index 81a7cba..b724a41 100644 > --- a/drivers/staging/omapdrm/Kconfig > +++ b/drivers/staging/omapdrm/Kconfig > @@ -2,7 +2,7 @@ > config DRM_OMAP > tristate "OMAP DRM" > depends on DRM && !CONFIG_FB_OMAP2 > - depends on ARCH_OMAP2PLUS > + depends on ARCH_OMAP2PLUS || ARCH_MULTIPLATFORM If you remove the omap include dependencies, is there any reason to keep ARCH_OMAP2PLUS here? And if you remove that, you don't need ARCH_MULTIPLATFORM either. omapdrm is not a driver for OMAP, even if the name so suggests. It's a driver for a display subsystem hardware, that happens to be used in OMAP (with the help of omapdss driver), and the tiler memory system used in OM= AP. I just recently removed omap dependencies from omapdss driver, and it now compiles fine on x86 config also. Tomi --------------enig1393AC961346839DB481BDCD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQIcBAEBAgAGBQJQjka3AAoJEPo9qoy8lh71ilwP/2xkAVKLb+4fyFH1HYCgRpCN SjzApDDE3z7g35jPw81DkaBfKacOybhGbzeUd63xA3QCGIpm61pnH/K6TO8o+NFW 8dL4rmRECK8vOin943/zxymBfKCoh4X8t44P20+OMM7DbEXryzerVOjfLPnMjG2E AmJXr42yVAYvMU+06vqhwCbQTQhNQ01LXXXw5W1UuxV/3jCHOTj6R9+6CNyt/BnG 6TdB+DVZKv0ih6tkYQVEDQ8bGuTVhCe3YXs70sRD+qLdjtTvbuQ6aMjvvgTay7Cd asgXjwQ9bo2FJPeFwu5Jx7ChwaVmkCqJd4Xg68NjWj5SshDHmefrHjcXtzZVmIFa 9i/zm6jrxGgDohFbZ/rgVRYUIa5aQL/u/sdC+xGQAIWb0djGmtcZYEn8IaMRvmZN 8Dswd/X5V9H1KEtUIiimUVtGduQJL4loCbCZxmL9EMRzuzK102S9Evr4AiT5+I8x LI7vbonQ9wQ81gitJ7TpUifJ/Z5IB1F+KfYd6nwo5lJQKRHdngLD274hqQt8XSMq cOFDMeCuHzZ9d+ks5SDKcL0SUZWy/XfKFdjOhOpTL8DsEj/RpSrYDVLal1DnDgsM 4F1ndwHA+faL4H8ZpcuxEoLn6B0jY/MWoKIY5soJpMhQtoSY/hkWx6Y+QfSoVNVm OsyhegG+rW4sZIkF5tME =Xohk -----END PGP SIGNATURE----- --------------enig1393AC961346839DB481BDCD-- --===============1858773988== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1858773988==--