From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Jonas Gorski <jonas.gorski@gmail.com>
Cc: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>,
John Crispin <blogic@openwrt.org>,
Maxime Bizon <mbizon@freebox.fr>,
Florian Fainelli <florian@openwrt.org>,
Kevin Cernekee <cernekee@gmail.com>
Subject: Re: [PATCH 1/3] MIPS: BCM63XX: add softreset register description for BCM6358
Date: Mon, 29 Oct 2012 14:56:27 +0400 [thread overview]
Message-ID: <508E60DB.6050005@mvista.com> (raw)
In-Reply-To: <1351430275-14509-2-git-send-email-jonas.gorski@gmail.com>
Hello.
On 28-10-2012 17:17, Jonas Gorski wrote:
> The softreset register description for BCM6358 was missing, so add it.
> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
> ---
> arch/mips/include/asm/mach-bcm63xx/bcm63xx_regs.h | 10 ++++++++++
> 1 files changed, 10 insertions(+), 0 deletions(-)
> diff --git a/arch/mips/include/asm/mach-bcm63xx/bcm63xx_regs.h b/arch/mips/include/asm/mach-bcm63xx/bcm63xx_regs.h
> index 12963d0..e84e602 100644
> --- a/arch/mips/include/asm/mach-bcm63xx/bcm63xx_regs.h
> +++ b/arch/mips/include/asm/mach-bcm63xx/bcm63xx_regs.h
[...]
> @@ -244,6 +245,15 @@
> SOFTRESET_6348_ACLC_MASK | \
> SOFTRESET_6348_ADSLMIPSPLL_MASK)
>
> +#define SOFTRESET_6358_SPI_MASK (1 << 0)
> +#define SOFTRESET_6358_ENET_MASK (1 << 2)
> +#define SOFTRESET_6358_MPI_MASK (1 << 3)
> +#define SOFTRESET_6358_EPHY_MASK (1 << 6)
> +#define SOFTRESET_6358_SAR_MASK (1 << 7)
> +#define SOFTRESET_6358_USBH_MASK (1 << 12)
> +#define SOFTRESET_6358_PCM_MASK (1 << 13)
> +#define SOFTRESET_6358_ADSL_MASK (1 << 14)
> +
Why not use BIT(n) instead of (1 << n)?
WBR, Sergei
next prev parent reply other threads:[~2012-10-29 10:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-28 13:17 [PATCH 0/3] add a reset helper for resetting cores Jonas Gorski
2012-10-28 13:17 ` [PATCH 1/3] MIPS: BCM63XX: add softreset register description for BCM6358 Jonas Gorski
2012-10-29 10:56 ` Sergei Shtylyov [this message]
2012-10-29 11:10 ` Florian Fainelli
2012-10-28 13:17 ` [PATCH 2/3] MIPS: BCM63XX: add core reset helper Jonas Gorski
2012-10-28 13:17 ` [PATCH 3/3] MIPS: BCM63XX: use the new " Jonas Gorski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508E60DB.6050005@mvista.com \
--to=sshtylyov@mvista.com \
--cc=blogic@openwrt.org \
--cc=cernekee@gmail.com \
--cc=florian@openwrt.org \
--cc=jonas.gorski@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=mbizon@freebox.fr \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.